Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37958 )
Change subject: util/testing: Remove romcc from testing ......................................................................
util/testing: Remove romcc from testing
Change-Id: If90193dc7c85133b10082c68a6cec6c1b0b35ffb Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/testing/Makefile.inc 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/37958/1
diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index 2028c84..8e3882f 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -97,7 +97,6 @@ unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/nvramcui BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/coreinfo BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml) - $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/romcc BLD=romcc MFLAGS= MAKEFLAGS= MAKETARGET=test junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=src/soc/nvidia/tegra124/lp0 BLD=tegra124_lp0 MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=src/soc/nvidia/tegra210/lp0 BLD=tegra120_lp0 MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml
@@ -124,10 +123,7 @@ test-tools: @echo "Build testing $(TOOLLIST)" $(foreach tool, $(TOOLLIST), $(MAKE) -C util/$(tool) clean ; ) - $(MAKE) -C util/romcc clean $(foreach tool, $(TOOLLIST), echo "Building $(tool)";export MFLAGS= ;export MAKEFLAGS= ;$(MAKE) -C util/$(tool) all V=$(V) Q=$(Q) || exit 1; ) - echo "Building romcc" - $(MAKE) -C util/romcc all test -j $(CPUS) V=$(V) Q=$(Q) echo "Testing broadcom/secimage" $(MAKE) -C util/broadcom/secimage test @echo "Running gitconfig tests" @@ -142,7 +138,6 @@ $(MAKE) clean $(MAKE) distclean $(foreach tool, $(TOOLLIST), $(MAKE) -C util/$(tool) clean ; ) - $(MAKE) -C util/romcc clean
.PHONY: test-basic test-lint test-abuild test-payloads .PHONY: test-tools test-cleanup test-help
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37958 )
Change subject: util/testing: Remove romcc from testing ......................................................................
Patch Set 1: Code-Review+1
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37958 )
Change subject: util/testing: Remove romcc from testing ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37958 )
Change subject: util/testing: Remove romcc from testing ......................................................................
util/testing: Remove romcc from testing
Change-Id: If90193dc7c85133b10082c68a6cec6c1b0b35ffb Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37958 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Jacob Garber jgarber1@ualberta.ca Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/testing/Makefile.inc 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, but someone else must approve Jacob Garber: Looks good to me, approved
diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index 2028c84..8e3882f 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -97,7 +97,6 @@ unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/nvramcui BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/coreinfo BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml) - $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/romcc BLD=romcc MFLAGS= MAKEFLAGS= MAKETARGET=test junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=src/soc/nvidia/tegra124/lp0 BLD=tegra124_lp0 MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=src/soc/nvidia/tegra210/lp0 BLD=tegra120_lp0 MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml
@@ -124,10 +123,7 @@ test-tools: @echo "Build testing $(TOOLLIST)" $(foreach tool, $(TOOLLIST), $(MAKE) -C util/$(tool) clean ; ) - $(MAKE) -C util/romcc clean $(foreach tool, $(TOOLLIST), echo "Building $(tool)";export MFLAGS= ;export MAKEFLAGS= ;$(MAKE) -C util/$(tool) all V=$(V) Q=$(Q) || exit 1; ) - echo "Building romcc" - $(MAKE) -C util/romcc all test -j $(CPUS) V=$(V) Q=$(Q) echo "Testing broadcom/secimage" $(MAKE) -C util/broadcom/secimage test @echo "Running gitconfig tests" @@ -142,7 +138,6 @@ $(MAKE) clean $(MAKE) distclean $(foreach tool, $(TOOLLIST), $(MAKE) -C util/$(tool) clean ; ) - $(MAKE) -C util/romcc clean
.PHONY: test-basic test-lint test-abuild test-payloads .PHONY: test-tools test-cleanup test-help
-
HAOUAS Elyes (Code Review) -
Jacob Garber (Code Review)
-
Patrick Georgi (Code Review)