Attention is currently required from: Boris Mittelberg, Brandon Breitenstein, Caveh Jalali, Hannah Williams, Kapil Porwal, Paul Menzel, Subrata Banik, Sukumar Ghorai, Tim Van Patten.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78321?usp=email )
Change subject: ec/google/chromeec: Add is_battery_present_and_above_critical_threshold
......................................................................
Patch Set 7:
(2 comments)
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/78321/comment/7241abbe_16436bbd :
PS6, Line 425: google_chromeec_is_battery_level_enough
use `google_chromeec_is_battery_present_and_above_critical_threshold()` […]
Thanks! This is updated to patchset#7.
https://review.coreboot.org/c/coreboot/+/78321/comment/f6ddfa26_11a6c479 :
PS6, Line 425: int google_chromeec_is_battery_level_enough(void);
Why not bool?
Thanks for the suggestion! This is updated to patchset#7.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78321?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib38be55bc42559bab4f12d5e8580ddc3e1a6acc1
Gerrit-Change-Number: 78321
Gerrit-PatchSet: 7
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Sat, 14 Oct 2023 21:09:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment