Change in coreboot[master]: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver
Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver ......................................................................
Patch Set 11:
(2 comments)
looks like GPIO driver is detected and loaded by the kernel, but my attempts to "export" gpio in sysfs are failing. It looks like something is missing. I suggest you split gpio part from the rest of the patch, so we can have two-step approach on this.
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... File src/soc/intel/xeon_sp/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 27: /* GPIO Community 0 */ : CreateDWordField (^RBUF, ^COM0._BAS, BAS0) : CreateDWordField (^RBUF, ^COM0._LEN, LEN0) :
this file doesn't compile. Non of these variables are defined.
actually it compiles fine, I was just stuffing this in wrong acpi namespace. there are a few issues however
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 37: GPIO_BASE_SIZE we do not have this defined, we need to find out this value for C620
-
Andrey Petrov (Code Review)