Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45475 )
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 35 insertions(+), 146 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/1
diff --git a/src/drivers/smmstore/smi.c b/src/drivers/smmstore/smi.c index b21423e..ba1d9e8 100644 --- a/src/drivers/smmstore/smi.c +++ b/src/drivers/smmstore/smi.c @@ -6,6 +6,7 @@ #include <smmstore.h> #include <stddef.h> #include <stdint.h> +#include <cpu/x86/save_state.h>
/* * Check that the given range is legal. @@ -24,7 +25,7 @@ }
/* Param is usually EBX, ret in EAX */ -uint32_t smmstore_exec(uint8_t command, void *param) +static uint32_t smmstore_exec(uint8_t command, void *param) { uint32_t ret = SMMSTORE_RET_FAILURE;
@@ -76,3 +77,27 @@
return ret; } + +void apmc_smmtore_handler(void) +{ + u8 sub_command; + u16 ax; + u32 ret, param; + const int apmc_node = get_apmc_node(APM_CNT_SMMSTORE); + + if (apmc_node < 0) + return; + + /* Command and return value in EAX */ + if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) + return; + + sub_command = (ax >> 8); + + /* Parameter buffer in EBX */ + if (get_save_state_reg(RBX, apmc_node, ¶m, sizeof(param))) + return; + + ret = smmstore_exec(sub_command, ¶m); + set_save_state_reg(RAX, apmc_node, &ret, sizeof(ret)); +} diff --git a/src/include/smmstore.h b/src/include/smmstore.h index ff0b720..3c50690 100644 --- a/src/include/smmstore.h +++ b/src/include/smmstore.h @@ -27,7 +27,7 @@ };
/* SMM responder */ -uint32_t smmstore_exec(uint8_t command, void *param); +void apmc_smmtore_handler(void);
/* implementation */ int smmstore_read_region(void *buf, ssize_t *bufsize); diff --git a/src/soc/amd/picasso/smihandler.c b/src/soc/amd/picasso/smihandler.c index 89df86f..e6be072 100644 --- a/src/soc/amd/picasso/smihandler.c +++ b/src/soc/amd/picasso/smihandler.c @@ -57,25 +57,6 @@ return NULL; }
-static void southbridge_smi_store(void) -{ - u8 sub_command; - amd64_smm_state_save_area_t *io_smi; - u32 reg_ebx; - - io_smi = find_save_state(APM_CNT_SMMSTORE); - if (!io_smi) - return; - /* Command and return value in EAX */ - sub_command = (io_smi->rax >> 8) & 0xff; - - /* Parameter buffer in EBX */ - reg_ebx = io_smi->rbx; - - /* drivers/smmstore/smi.c */ - io_smi->rax = smmstore_exec(sub_command, (void *)reg_ebx); -} - static void sb_apmc_smi_handler(void) { const uint8_t cmd = inb(pm_acpi_smi_cmd_port()); @@ -93,7 +74,7 @@ break; case APM_CNT_SMMSTORE: if (CONFIG(SMMSTORE)) - southbridge_smi_store(); + apmc_smmtore_handler(); break; case APM_CNT_SMMINFO: psp_notify_smm(); diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c index d55c545..2163c80 100644 --- a/src/soc/amd/stoneyridge/smihandler.c +++ b/src/soc/amd/stoneyridge/smihandler.c @@ -55,25 +55,6 @@ return NULL; }
-static void southbridge_smi_store(void) -{ - u8 sub_command; - amd64_smm_state_save_area_t *io_smi; - u32 reg_ebx; - - io_smi = find_save_state(APM_CNT_SMMSTORE); - if (!io_smi) - return; - /* Command and return value in EAX */ - sub_command = (io_smi->rax >> 8) & 0xff; - - /* Parameter buffer in EBX */ - reg_ebx = io_smi->rbx; - - /* drivers/smmstore/smi.c */ - io_smi->rax = smmstore_exec(sub_command, (void *)reg_ebx); -} - static void sb_apmc_smi_handler(void) { const uint8_t cmd = inb(pm_acpi_smi_cmd_port()); @@ -91,7 +72,7 @@ break; case APM_CNT_SMMSTORE: if (CONFIG(SMMSTORE)) - southbridge_smi_store(); + apmc_smmtore_handler(); break; }
diff --git a/src/soc/intel/baytrail/smihandler.c b/src/soc/intel/baytrail/smihandler.c index bfe933f..9348ae0 100644 --- a/src/soc/intel/baytrail/smihandler.c +++ b/src/soc/intel/baytrail/smihandler.c @@ -240,25 +240,6 @@ LPSS_ACPI_MODE_DISABLE(SPI); }
-static void southbridge_smi_store(void) -{ - u8 sub_command, ret; - em64t100_smm_state_save_area_t *io_smi = smi_apmc_find_state_save(APM_CNT_SMMSTORE); - uint32_t reg_ebx; - - if (!io_smi) - return; - /* Command and return value in EAX */ - sub_command = (io_smi->rax >> 8) & 0xff; - - /* Parameter buffer in EBX */ - reg_ebx = io_smi->rbx; - - /* drivers/smmstore/smi.c */ - ret = smmstore_exec(sub_command, (void *)reg_ebx); - io_smi->rax = ret; -} - static void southbridge_smi_apmc(void) { uint8_t reg8; @@ -314,7 +295,7 @@ break; case APM_CNT_SMMSTORE: if (CONFIG(SMMSTORE)) - southbridge_smi_store(); + apmc_smmtore_handler(); break; }
diff --git a/src/soc/intel/braswell/smihandler.c b/src/soc/intel/braswell/smihandler.c index f6ac703..6f8cd62 100644 --- a/src/soc/intel/braswell/smihandler.c +++ b/src/soc/intel/braswell/smihandler.c @@ -220,25 +220,6 @@ return NULL; }
-static void southbridge_smi_store(void) -{ - u8 sub_command, ret; - em64t100_smm_state_save_area_t *io_smi = smi_apmc_find_state_save(APM_CNT_SMMSTORE); - uint32_t reg_ebx; - - if (!io_smi) - return; - /* Command and return value in EAX */ - sub_command = (io_smi->rax >> 8) & 0xff; - - /* Parameter buffer in EBX */ - reg_ebx = io_smi->rbx; - - /* drivers/smmstore/smi.c */ - ret = smmstore_exec(sub_command, (void *)reg_ebx); - io_smi->rax = ret; -} - static void southbridge_smi_apmc(void) { uint8_t reg8; @@ -291,7 +272,7 @@ break; case APM_CNT_SMMSTORE: if (CONFIG(SMMSTORE)) - southbridge_smi_store(); + apmc_smmtore_handler(); break; }
diff --git a/src/soc/intel/broadwell/smihandler.c b/src/soc/intel/broadwell/smihandler.c index ea5bf8a..a223bf5 100644 --- a/src/soc/intel/broadwell/smihandler.c +++ b/src/soc/intel/broadwell/smihandler.c @@ -267,26 +267,6 @@ return NULL; }
-static void southbridge_smi_store(void) -{ - u8 sub_command, ret; - em64t101_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(APM_CNT_SMMSTORE); - uint32_t reg_ebx; - - if (!io_smi) - return; - /* Command and return value in EAX */ - sub_command = (io_smi->rax >> 8) & 0xff; - - /* Parameter buffer in EBX */ - reg_ebx = io_smi->rbx; - - /* drivers/smmstore/smi.c */ - ret = smmstore_exec(sub_command, (void *)reg_ebx); - io_smi->rax = ret; -} - static void southbridge_smi_apmc(void) { u8 reg8; @@ -330,7 +310,7 @@ break; case APM_CNT_SMMSTORE: if (CONFIG(SMMSTORE)) - southbridge_smi_store(); + apmc_smmtore_handler(); break; }
diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c index 77eaad9..b629ef2 100644 --- a/src/soc/intel/common/block/smm/smihandler.c +++ b/src/soc/intel/common/block/smm/smihandler.c @@ -340,7 +340,7 @@ break; case APM_CNT_SMMSTORE: if (CONFIG(SMMSTORE)) - southbridge_smi_store(save_state_ops); + apmc_smmtore_handler(); break; case APM_CNT_FINALIZE: finalize(); diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c index 3ce4ba8..ff61c6f 100644 --- a/src/southbridge/intel/common/smihandler.c +++ b/src/southbridge/intel/common/smihandler.c @@ -230,26 +230,6 @@ return NULL; }
-static void southbridge_smi_store(void) -{ - u8 sub_command, ret; - em64t101_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(APM_CNT_SMMSTORE); - uintptr_t reg_rbx; - - if (!io_smi) - return; - /* Command and return value in EAX */ - sub_command = (io_smi->rax >> 8) & 0xff; - - /* Parameter buffer in EBX */ - reg_rbx = (uintptr_t)io_smi->rbx; - - /* drivers/smmstore/smi.c */ - ret = smmstore_exec(sub_command, (void *)reg_rbx); - io_smi->rax = ret; -} - static int mainboard_finalized = 0;
static void southbridge_smi_apmc(void) @@ -305,7 +285,7 @@ break; case APM_CNT_SMMSTORE: if (CONFIG(SMMSTORE)) - southbridge_smi_store(); + apmc_smmtore_handler(); break; }
diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c index 9464904..a033d68 100644 --- a/src/southbridge/intel/lynxpoint/smihandler.c +++ b/src/southbridge/intel/lynxpoint/smihandler.c @@ -218,26 +218,6 @@ return NULL; }
-static void southbridge_smi_store(void) -{ - u8 sub_command, ret; - em64t101_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(APM_CNT_SMMSTORE); - uint32_t reg_ebx; - - if (!io_smi) - return; - /* Command and return value in EAX */ - sub_command = (io_smi->rax >> 8) & 0xff; - - /* Parameter buffer in EBX */ - reg_ebx = io_smi->rbx; - - /* drivers/smmstore/smi.c */ - ret = smmstore_exec(sub_command, (void *)reg_ebx); - io_smi->rax = ret; -} - static void southbridge_smi_apmc(void) { u8 reg8; @@ -306,7 +286,7 @@ break; case APM_CNT_SMMSTORE: if (CONFIG(SMMSTORE)) - southbridge_smi_store(); + apmc_smmtore_handler(); break; }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45475 )
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45475/1/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/drivers/smmstore/smi.c@... PS1, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/drivers/smmstore/smi.c@... PS1, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/amd/picasso/smihand... File src/soc/amd/picasso/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/amd/picasso/smihand... PS1, Line 77: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/amd/stoneyridge/smi... File src/soc/amd/stoneyridge/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/amd/stoneyridge/smi... PS1, Line 75: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/baytrail/smih... File src/soc/intel/baytrail/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/baytrail/smih... PS1, Line 298: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/braswell/smih... File src/soc/intel/braswell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/braswell/smih... PS1, Line 275: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/broadwell/smi... File src/soc/intel/broadwell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/broadwell/smi... PS1, Line 313: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/common/block/... File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/common/block/... PS1, Line 343: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/southbridge/intel/lynxp... PS1, Line 289: apmc_smmtore_handler(); code indent should use tabs where possible
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45475 )
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
Patch Set 2:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45475/2/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/45475/2/src/drivers/smmstore/smi.c@... PS2, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/2/src/drivers/smmstore/smi.c@... PS2, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/amd/picasso/smihand... File src/soc/amd/picasso/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/amd/picasso/smihand... PS2, Line 77: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/amd/stoneyridge/smi... File src/soc/amd/stoneyridge/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/amd/stoneyridge/smi... PS2, Line 75: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/intel/baytrail/smih... File src/soc/intel/baytrail/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/intel/baytrail/smih... PS2, Line 302: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/intel/braswell/smih... File src/soc/intel/braswell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/intel/braswell/smih... PS2, Line 278: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/intel/broadwell/smi... File src/soc/intel/broadwell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/intel/broadwell/smi... PS2, Line 321: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/intel/common/block/... File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/2/src/soc/intel/common/block/... PS2, Line 346: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/2/src/southbridge/intel/lynxp... PS2, Line 292: apmc_smmtore_handler(); code indent should use tabs where possible
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45475 )
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
Patch Set 3:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45475/3/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/45475/3/src/drivers/smmstore/smi.c@... PS3, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/3/src/drivers/smmstore/smi.c@... PS3, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/amd/picasso/smihand... File src/soc/amd/picasso/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/amd/picasso/smihand... PS3, Line 77: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/amd/stoneyridge/smi... File src/soc/amd/stoneyridge/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/amd/stoneyridge/smi... PS3, Line 75: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/intel/baytrail/smih... File src/soc/intel/baytrail/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/intel/baytrail/smih... PS3, Line 302: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/intel/braswell/smih... File src/soc/intel/braswell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/intel/braswell/smih... PS3, Line 278: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/intel/broadwell/smi... File src/soc/intel/broadwell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/intel/broadwell/smi... PS3, Line 321: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/intel/common/block/... File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/3/src/soc/intel/common/block/... PS3, Line 346: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/3/src/southbridge/intel/lynxp... PS3, Line 292: apmc_smmtore_handler(); code indent should use tabs where possible
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45475
to look at the new patch set (#4).
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 35 insertions(+), 175 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/4
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45475
to look at the new patch set (#6).
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 35 insertions(+), 228 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/6
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45475 )
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
Patch Set 7:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45475/7/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/45475/7/src/drivers/smmstore/smi.c@... PS7, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/7/src/drivers/smmstore/smi.c@... PS7, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/amd/picasso/smihand... File src/soc/amd/picasso/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/amd/picasso/smihand... PS7, Line 36: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/amd/stoneyridge/smi... File src/soc/amd/stoneyridge/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/amd/stoneyridge/smi... PS7, Line 34: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/intel/baytrail/smih... File src/soc/intel/baytrail/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/intel/baytrail/smih... PS7, Line 302: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/intel/braswell/smih... File src/soc/intel/braswell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/intel/braswell/smih... PS7, Line 278: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/intel/broadwell/smi... File src/soc/intel/broadwell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/intel/broadwell/smi... PS7, Line 321: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/intel/common/block/... File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/7/src/soc/intel/common/block/... PS7, Line 346: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/7/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/7/src/southbridge/intel/lynxp... PS7, Line 292: apmc_smmtore_handler(); code indent should use tabs where possible
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45475
to look at the new patch set (#8).
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 35 insertions(+), 228 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/8
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45475
to look at the new patch set (#10).
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 35 insertions(+), 249 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/10
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45475
to look at the new patch set (#11).
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/pch/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 32 insertions(+), 253 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/11
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45475
to look at the new patch set (#12).
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/pch/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 32 insertions(+), 253 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/12
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45475
to look at the new patch set (#13).
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/pch/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 32 insertions(+), 253 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/13
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45475
to look at the new patch set (#15).
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/pch/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 32 insertions(+), 253 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/15
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45475
to look at the new patch set (#16).
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
cpu/x86/smm: Move smmstore entry to a common place
Now that SMM save states are handled in a common place so can the SMMSTORE calls entry.
Change-Id: Ieb8d01a2d33e9214c3df7f909dcfab49a05fffff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/smmstore/smi.c M src/include/smmstore.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/pch/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 10 files changed, 32 insertions(+), 253 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45475/16
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45475 )
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45475/17/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/45475/17/src/drivers/smmstore/smi.c... PS17, Line 145: void apmc_smmtore_handler(void) smmstore
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45475?usp=email )
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Arthur Heymans (Code Review) -
build bot (Jenkins) (Code Review)
-
Martin L Roth (Code Review)
-
Patrick Rudolph (Code Review)