HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32101
Change subject: Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID}
Change-Id: I6ad986c69c51aff8e7e49e31ffa130ff14e9a50e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/Kconfig M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/asrock/b75pro3-m/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asus/h61m-cs/Kconfig M src/mainboard/asus/maximus_iv_gene-z/Kconfig M src/mainboard/asus/p8h61-m_lx/Kconfig M src/mainboard/asus/p8h61-m_pro/Kconfig M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/8770w/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/revolve_810_g1/Kconfig M src/mainboard/intel/dcp847ske/Kconfig M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/sapphire/pureplatinumh61/Kconfig M src/mainboard/supermicro/x10slm-f/Kconfig M util/autoport/bd82x6x.go 38 files changed, 0 insertions(+), 304 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/32101/1
diff --git a/src/mainboard/aopen/dxplplusu/Kconfig b/src/mainboard/aopen/dxplplusu/Kconfig index 3a729ce..905ddd5 100644 --- a/src/mainboard/aopen/dxplplusu/Kconfig +++ b/src/mainboard/aopen/dxplplusu/Kconfig @@ -33,12 +33,4 @@ hex default 0x4000
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x0 - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x0 - endif # BOARD_AOPEN_DXPLPLUSU diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index 9d4047d..82f120a 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -31,14 +31,6 @@ string default "8086,0116"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x7270 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x8086 - config DRAM_RESET_GATE_GPIO int default 60 diff --git a/src/mainboard/asrock/b75pro3-m/Kconfig b/src/mainboard/asrock/b75pro3-m/Kconfig index 5fc3c5e..8db0eba 100644 --- a/src/mainboard/asrock/b75pro3-m/Kconfig +++ b/src/mainboard/asrock/b75pro3-m/Kconfig @@ -37,14 +37,6 @@ string default "B75 Pro3-M"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x1e49 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1849 - config MAX_CPUS int default 8 diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig index 55f1637..db2768d 100644 --- a/src/mainboard/asrock/h81m-hds/Kconfig +++ b/src/mainboard/asrock/h81m-hds/Kconfig @@ -56,14 +56,6 @@ string default "H81M-HDS"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x8c5c - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1849 - config MAX_CPUS int default 8 diff --git a/src/mainboard/asus/h61m-cs/Kconfig b/src/mainboard/asus/h61m-cs/Kconfig index d21c761..60dafda 100644 --- a/src/mainboard/asus/h61m-cs/Kconfig +++ b/src/mainboard/asus/h61m-cs/Kconfig @@ -25,14 +25,6 @@ string default "H61M-CS"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x844d - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1043 - config MAX_CPUS int default 8 diff --git a/src/mainboard/asus/maximus_iv_gene-z/Kconfig b/src/mainboard/asus/maximus_iv_gene-z/Kconfig index 92d7840..a0bc318 100644 --- a/src/mainboard/asus/maximus_iv_gene-z/Kconfig +++ b/src/mainboard/asus/maximus_iv_gene-z/Kconfig @@ -46,14 +46,6 @@ string default "8086,0112"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x844d - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1043 - config MAX_CPUS int default 8 diff --git a/src/mainboard/asus/p8h61-m_lx/Kconfig b/src/mainboard/asus/p8h61-m_lx/Kconfig index cc2f8a9..010641a 100644 --- a/src/mainboard/asus/p8h61-m_lx/Kconfig +++ b/src/mainboard/asus/p8h61-m_lx/Kconfig @@ -43,14 +43,6 @@ string default "P8H61-M LX"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x844d - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1043 - config MAX_CPUS int default 8 diff --git a/src/mainboard/asus/p8h61-m_pro/Kconfig b/src/mainboard/asus/p8h61-m_pro/Kconfig index 4d24187..cdd70d0 100644 --- a/src/mainboard/asus/p8h61-m_pro/Kconfig +++ b/src/mainboard/asus/p8h61-m_pro/Kconfig @@ -47,14 +47,6 @@ string default "8086,0152"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x844d - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1043 - config MAX_CPUS int default 8 diff --git a/src/mainboard/compulab/intense_pc/Kconfig b/src/mainboard/compulab/intense_pc/Kconfig index 0bfde49..ff697b9 100644 --- a/src/mainboard/compulab/intense_pc/Kconfig +++ b/src/mainboard/compulab/intense_pc/Kconfig @@ -28,14 +28,6 @@ string default "8086,0166"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x7270 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x8086 - config DRAM_RESET_GATE_GPIO # FIXME: check this int default 60 diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig index 5fba47a..5e46365 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig @@ -40,14 +40,6 @@ string default "GA-H61M-S2PV"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x5001 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1458 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index 570a1b3..24797be 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -40,14 +40,6 @@ string default "pci8086,0106.rom"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1ae0 - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0xc000 - config MAINBOARD_VENDOR string default "Hewlett-Packard" diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index f2c9b20..1a31da7 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -41,12 +41,4 @@ string default "pci8086,0106.rom"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1ae0 - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0xc000 - endif # BOARD_GOOGLE_PARROT diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index c9b67cc..8b3eb0f 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -43,12 +43,4 @@ string default "8086,0156"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1ae0 - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0xc000 - endif # BOARD_GOOGLE_STOUT diff --git a/src/mainboard/hp/2570p/Kconfig b/src/mainboard/hp/2570p/Kconfig index f9da619..ff91e4d 100644 --- a/src/mainboard/hp/2570p/Kconfig +++ b/src/mainboard/hp/2570p/Kconfig @@ -49,14 +49,6 @@ string default "8086,0166"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x17df - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x103c - config MAX_CPUS int default 8 diff --git a/src/mainboard/hp/2760p/Kconfig b/src/mainboard/hp/2760p/Kconfig index af3e31b..ab29836 100644 --- a/src/mainboard/hp/2760p/Kconfig +++ b/src/mainboard/hp/2760p/Kconfig @@ -49,14 +49,6 @@ string default "8086,0116"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x162a - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x103c - config MAX_CPUS int default 8 diff --git a/src/mainboard/hp/8460p/Kconfig b/src/mainboard/hp/8460p/Kconfig index ca737ea..ca97cd6 100644 --- a/src/mainboard/hp/8460p/Kconfig +++ b/src/mainboard/hp/8460p/Kconfig @@ -52,14 +52,6 @@ string default "8086,0116"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x161c - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x103c - config MAX_CPUS int default 8 diff --git a/src/mainboard/hp/8470p/Kconfig b/src/mainboard/hp/8470p/Kconfig index d8bf5ec..f23c02f 100644 --- a/src/mainboard/hp/8470p/Kconfig +++ b/src/mainboard/hp/8470p/Kconfig @@ -50,14 +50,6 @@ string default "8086,0166"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x179b - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x103c - config MAX_CPUS int default 8 diff --git a/src/mainboard/hp/8770w/Kconfig b/src/mainboard/hp/8770w/Kconfig index c60283d..6752085 100644 --- a/src/mainboard/hp/8770w/Kconfig +++ b/src/mainboard/hp/8770w/Kconfig @@ -41,14 +41,6 @@ string default "EliteBook 8770w"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x176c - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x103c - config MAX_CPUS int default 8 diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig index c4b9d6d..cbfb0ed 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig @@ -35,14 +35,6 @@ string default "8086,0102"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x1495 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x103c - config DRAM_RESET_GATE_GPIO int default 60 diff --git a/src/mainboard/hp/folio_9470m/Kconfig b/src/mainboard/hp/folio_9470m/Kconfig index f65aeed..06ca793 100644 --- a/src/mainboard/hp/folio_9470m/Kconfig +++ b/src/mainboard/hp/folio_9470m/Kconfig @@ -35,14 +35,6 @@ string default "8086,0166"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x18df - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x103c - config MAX_CPUS int default 8 diff --git a/src/mainboard/hp/revolve_810_g1/Kconfig b/src/mainboard/hp/revolve_810_g1/Kconfig index a08a9e5..475e978 100644 --- a/src/mainboard/hp/revolve_810_g1/Kconfig +++ b/src/mainboard/hp/revolve_810_g1/Kconfig @@ -37,14 +37,6 @@ string default "8086,0166"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x18f8 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x103c - config DRAM_RESET_GATE_GPIO # FIXME: check this int default 60 diff --git a/src/mainboard/intel/dcp847ske/Kconfig b/src/mainboard/intel/dcp847ske/Kconfig index dd7f1ca..b1c7bab 100644 --- a/src/mainboard/intel/dcp847ske/Kconfig +++ b/src/mainboard/intel/dcp847ske/Kconfig @@ -41,14 +41,6 @@ string default "8086,0106"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x2044 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x8086 - config MAX_CPUS int default 2 diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig index b85d938..043eb01 100644 --- a/src/mainboard/kontron/ktqm77/Kconfig +++ b/src/mainboard/kontron/ktqm77/Kconfig @@ -31,14 +31,6 @@ string default "pci8086,0166.rom"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x0000 # TODO - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x0000 # TODO - config MAINBOARD_VENDOR string default "Kontron" diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig index a807316..4495d79 100644 --- a/src/mainboard/lenovo/l520/Kconfig +++ b/src/mainboard/lenovo/l520/Kconfig @@ -34,14 +34,6 @@ string default "8086,0126"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21dd - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - config DRAM_RESET_GATE_GPIO int default 10 diff --git a/src/mainboard/lenovo/s230u/Kconfig b/src/mainboard/lenovo/s230u/Kconfig index 714f13f..9200ad5 100644 --- a/src/mainboard/lenovo/s230u/Kconfig +++ b/src/mainboard/lenovo/s230u/Kconfig @@ -52,12 +52,4 @@ string default "8086,0166"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x2205 - endif # BOARD_LENOVO_S230U diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index f40e9c0..ce81907 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -56,14 +56,6 @@ string default "8086,0126"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21ce - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig index 71b94af..c5efb55 100644 --- a/src/mainboard/lenovo/t420s/Kconfig +++ b/src/mainboard/lenovo/t420s/Kconfig @@ -55,14 +55,6 @@ string default "8086,0126"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21d2 - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig index 687edea..dbeaadb 100644 --- a/src/mainboard/lenovo/t430/Kconfig +++ b/src/mainboard/lenovo/t430/Kconfig @@ -38,14 +38,6 @@ string default "8086,0166"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21f3 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - config DRAM_RESET_GATE_GPIO int default 10 diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig index 47ff441..bad1837 100644 --- a/src/mainboard/lenovo/t430s/Kconfig +++ b/src/mainboard/lenovo/t430s/Kconfig @@ -60,15 +60,6 @@ string default "pci8086,0166.rom"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21fb if BOARD_LENOVO_T430S - default 0x2208 if BOARD_LENOVO_T431S - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index c414083..06f296b 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -65,14 +65,6 @@ string default "pci8086,0126.rom"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21cf - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 14f9fb2..b36460d 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -62,14 +62,6 @@ default "pci8086,0106.rom" if BOARD_LENOVO_T530 default "pci8086,0166.rom" if BOARD_LENOVO_W530
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21fa - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig index 2f936a9..e7da8d0 100644 --- a/src/mainboard/lenovo/x131e/Kconfig +++ b/src/mainboard/lenovo/x131e/Kconfig @@ -37,12 +37,4 @@ int default 2
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21fe - endif # BOARD_LENOVO_X131E diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig index 202fabd..520853c 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig +++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig @@ -54,12 +54,4 @@ string default "8086,0166"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21fa - endif # BOARD_LENOVO_X1_CARBON_GEN1 diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 70245d2..16f42e8 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -69,13 +69,4 @@ default "8086,0116" if BOARD_LENOVO_X220I default "8086,0126"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21db if BOARD_LENOVO_X220 || BOARD_LENOVO_X220I - default 0x21e8 if BOARD_LENOVO_X1 - endif # BOARD_LENOVO_X220 || BOARD_LENOVO_X220I || BOARD_LENOVO_X1 diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 3ec537a..5b34b83 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -55,12 +55,4 @@ string default "8086,0166"
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x17aa - -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x21fa - endif # BOARD_LENOVO_X230 diff --git a/src/mainboard/sapphire/pureplatinumh61/Kconfig b/src/mainboard/sapphire/pureplatinumh61/Kconfig index 85b2f36..13a93c5 100644 --- a/src/mainboard/sapphire/pureplatinumh61/Kconfig +++ b/src/mainboard/sapphire/pureplatinumh61/Kconfig @@ -32,14 +32,6 @@ string default "8086,0162"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x1007 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x174b - config DRAM_RESET_GATE_GPIO int default 60 diff --git a/src/mainboard/supermicro/x10slm-f/Kconfig b/src/mainboard/supermicro/x10slm-f/Kconfig index 6bf0b2a..430bed3 100644 --- a/src/mainboard/supermicro/x10slm-f/Kconfig +++ b/src/mainboard/supermicro/x10slm-f/Kconfig @@ -44,14 +44,6 @@ string default "X10SLM+-F"
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x0803 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x15d9 - config MAX_CPUS int default 8 diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 265cb6f..a97ff1d 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -181,12 +181,6 @@ } KconfigComment["DRAM_RESET_GATE_GPIO"] = "FIXME: check this"
- /* Not strictly speaking correct. These subsys/subvendor referer to PCI devices. - But most systems don't have any of those. But the config needs to be set - nevertheless. So set it to southbridge subsys/subvendor. */ - KconfigHex["MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID"] = uint32(GetLE16(addr.ConfigDump[0x2c:0x2e])) - KconfigHex["MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID"] = uint32(GetLE16(addr.ConfigDump[0x2e:0x30])) - ich9GetFlashSize(ctx)
DSDTDefines = append(DSDTDefines,
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Patch Set 1: Code-Review-1
The commit https://review.coreboot.org/#/c/coreboot/+/31987/ failed to rename the Kconfig to CONFIG_SUBSYSTEM_VENDOR_ID/CONFIG_SUBSYSTEM_DEVICE_ID
Hello Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Angel Pons, Patrick Rudolph, Tristan Corrick, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32101
to look at the new patch set (#2).
Change subject: src/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
src/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID}
Change-Id: I6ad986c69c51aff8e7e49e31ffa130ff14e9a50e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/Kconfig M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/asrock/b75pro3-m/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asus/h61m-cs/Kconfig M src/mainboard/asus/maximus_iv_gene-z/Kconfig M src/mainboard/asus/p8h61-m_lx/Kconfig M src/mainboard/asus/p8h61-m_pro/Kconfig M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/8770w/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/revolve_810_g1/Kconfig M src/mainboard/intel/dcp847ske/Kconfig M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/sapphire/pureplatinumh61/Kconfig M src/mainboard/supermicro/x10slm-f/Kconfig M util/autoport/bd82x6x.go 38 files changed, 0 insertions(+), 304 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/32101/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: src/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Patch Set 2: -Code-Review
While removing the Kconfig, please add "subsystemid ???? ???? inherit" in devicetree.cb instead.
Kyösti Mälkki has uploaded a new patch set (#3) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID}
References to these were removed in commits
dbd3132 sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem() 00bb441 sb/intel/lynxpoint: Remove PCI bridge function
The entries removed here under mb/ were already unused because of one of the three reasons below:
With sb/intel/lynxpoint there was no PCI bridge present in silicon Devicetree has 'pci 1e.0 off' disabling the PCI bridge function Values were set to 0x0
Change-Id: I6ad986c69c51aff8e7e49e31ffa130ff14e9a50e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/aopen/dxplplusu/Kconfig M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/asrock/b75pro3-m/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asus/h61m-cs/Kconfig M src/mainboard/asus/maximus_iv_gene-z/Kconfig M src/mainboard/asus/p8h61-m_lx/Kconfig M src/mainboard/asus/p8h61-m_pro/Kconfig M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/8770w/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/revolve_810_g1/Kconfig M src/mainboard/intel/dcp847ske/Kconfig M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/sapphire/pureplatinumh61/Kconfig M src/mainboard/supermicro/x10slm-f/Kconfig 34 files changed, 0 insertions(+), 274 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/32101/3
Hello Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Angel Pons, Patrick Rudolph, Tristan Corrick, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32101
to look at the new patch set (#4).
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID}
References to these were removed in commits
dbd3132 sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem() 00bb441 sb/intel/lynxpoint: Remove PCI bridge function
The entries removed here under mb/ were already unused because of one of the three reasons below:
With sb/intel/lynxpoint there was no PCI bridge present in silicon Devicetree has 'pci 1e.0 off' disabling the PCI bridge function Values were set to 0x0
Change-Id: I6ad986c69c51aff8e7e49e31ffa130ff14e9a50e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/Kconfig M src/mainboard/aopen/dxplplusu/devicetree.cb M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/apple/macbookair4_2/devicetree.cb M src/mainboard/asrock/b75pro3-m/Kconfig M src/mainboard/asrock/b75pro3-m/devicetree.cb M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asrock/h81m-hds/devicetree.cb M src/mainboard/asus/h61m-cs/Kconfig M src/mainboard/asus/maximus_iv_gene-z/Kconfig M src/mainboard/asus/p8h61-m_lx/Kconfig M src/mainboard/asus/p8h61-m_pro/Kconfig M src/mainboard/asus/p8h61-m_pro/devicetree.cb M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/compulab/intense_pc/devicetree.cb M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/butterfly/devicetree.cb M src/mainboard/google/parrot/Kconfig M src/mainboard/google/parrot/devicetree.cb M src/mainboard/google/stout/Kconfig M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2570p/devicetree.cb M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/2760p/devicetree.cb M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8460p/devicetree.cb M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/8470p/devicetree.cb M src/mainboard/hp/8770w/Kconfig M src/mainboard/hp/8770w/devicetree.cb M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/folio_9470m/devicetree.cb M src/mainboard/hp/revolve_810_g1/Kconfig M src/mainboard/hp/revolve_810_g1/devicetree.cb M src/mainboard/intel/dcp847ske/Kconfig M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/kontron/ktqm77/devicetree.cb M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/l520/devicetree.cb M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t430s/devicetree.cb M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/sapphire/pureplatinumh61/Kconfig M src/mainboard/sapphire/pureplatinumh61/devicetree.cb M src/mainboard/supermicro/x10slm-f/Kconfig 62 files changed, 28 insertions(+), 274 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/32101/4
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Patch Set 4: Code-Review-1
The referenced boards do not use lynxpoint at all.
Hello Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Angel Pons, Patrick Rudolph, Tristan Corrick, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32101
to look at the new patch set (#5).
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID}
References to these were removed in commits
dbd3132 sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem() 00bb441 sb/intel/lynxpoint: Remove PCI bridge function
The entries removed here under mb/ were already unused because of one of the three reasons below:
With sb/intel/lynxpoint there was no PCI bridge present in silicon Devicetree has 'pci 1e.0 off' disabling the PCI bridge function Values were set to 0x0
Change-Id: I6ad986c69c51aff8e7e49e31ffa130ff14e9a50e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/aopen/dxplplusu/Kconfig M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/asrock/b75pro3-m/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asus/h61m-cs/Kconfig M src/mainboard/asus/maximus_iv_gene-z/Kconfig M src/mainboard/asus/p8h61-m_lx/Kconfig M src/mainboard/asus/p8h61-m_pro/Kconfig M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/8770w/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/revolve_810_g1/Kconfig M src/mainboard/intel/dcp847ske/Kconfig M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/sapphire/pureplatinumh61/Kconfig M src/mainboard/supermicro/x10slm-f/Kconfig 34 files changed, 0 insertions(+), 274 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/32101/5
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Patch Set 5:
Patch Set 4: Code-Review-1
The referenced boards do not use lynxpoint at all.
Only one of the reasons implied lynxpoint.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Patch Set 5:
While removing the Kconfig, please add "subsystemid ???? ???? inherit" in devicetree.cb instead.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Patch Set 5:
Patch Set 5:
While removing the Kconfig, please add "subsystemid ???? ???? inherit" in devicetree.cb instead.
Why and where? Give me some sample.
The removed Kconfig was only connected to disabled or non-existing PCI bridge device 0:1e.0.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Patch Set 5:
Patch Set 5:
While removing the Kconfig, please add "subsystemid ???? ????
inherit" in devicetree.cb instead.
Why and where? Give me some sample.
The removed Kconfig was only connected to disabled or non-existing PCI bridge device 0:1e.0.
Nevermind, I thought it was used for all PCI devices.
Anyway, shouldn't all enabled P2P devices have this subsystemid added in devicetree?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Patch Set 5:
Patch Set 5:
While removing the Kconfig, please add "subsystemid ???? ????
inherit" in devicetree.cb instead.
Why and where? Give me some sample.
The removed Kconfig was only connected to disabled or
non-existing
PCI bridge device 0:1e.0.
Nevermind, I thought it was used for all PCI devices.
Anyway, shouldn't all enabled P2P devices have this subsystemid added in devicetree?
as patch set 4 ?
Hello Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Angel Pons, Patrick Rudolph, Tristan Corrick, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32101
to look at the new patch set (#6).
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID}
References to these were removed in commits
dbd3132 sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem() 00bb441 sb/intel/lynxpoint: Remove PCI bridge function
The entries removed here under mb/ were already unused because of one of the three reasons below:
With sb/intel/lynxpoint there was no PCI bridge present in silicon Devicetree has 'pci 1e.0 off' disabling the PCI bridge function Values were set to 0x0
Change-Id: I6ad986c69c51aff8e7e49e31ffa130ff14e9a50e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/Kconfig M src/mainboard/aopen/dxplplusu/devicetree.cb M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/asrock/b75pro3-m/Kconfig M src/mainboard/asrock/b75pro3-m/devicetree.cb M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asus/h61m-cs/Kconfig M src/mainboard/asus/maximus_iv_gene-z/Kconfig M src/mainboard/asus/p8h61-m_lx/Kconfig M src/mainboard/asus/p8h61-m_pro/Kconfig M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/8770w/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/revolve_810_g1/Kconfig M src/mainboard/intel/dcp847ske/Kconfig M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/sapphire/pureplatinumh61/Kconfig M src/mainboard/supermicro/x10slm-f/Kconfig 37 files changed, 3 insertions(+), 274 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/32101/6
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32101 )
Change subject: mb/*/Kconfig: Remove unused MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ......................................................................
Abandoned
see https://review.coreboot.org/#/c/coreboot/+/32107/