Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30986
Change subject: mb/google/poppy/variant/nami: disable unused usb2 ports ......................................................................
mb/google/poppy/variant/nami: disable unused usb2 ports
disable unused usb2 ports of bard and ekko skus
BUG=none TEST=build a test firmware and run lsusb to check usb ports
Change-Id: I2ef3cd17ada8b65c96bc80675650905949f235e1 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/30986/1
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index c656954..8592cae 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -267,6 +267,10 @@ case SKU_2_EKKO: case SKU_3_EKKO: pl2_id = PL2_ID_BARD_EKKO; + cfg->usb2_ports[5].enable = 0; + cfg->usb2_ports[7].enable = 0; + cfg->usb2_ports[8].enable = 0; + cfg->usb2_ports[9].enable = 0; break; default: break;
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30986 )
Change subject: mb/google/poppy/variant/nami: disable unused usb2 ports ......................................................................
Patch Set 1: Code-Review+1
Hello Vincent Wang, Shelley Chen, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30986
to look at the new patch set (#2).
Change subject: mb/google/poppy/variant/nami: disable unused usb2 ports ......................................................................
mb/google/poppy/variant/nami: disable unused usb2 ports
disable unused usb2 ports of bard and ekko skus
BUG=120874946 TEST=build a test firmware and run lsusb to check usb ports
Change-Id: I2ef3cd17ada8b65c96bc80675650905949f235e1 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/30986/2
Vincent Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30986 )
Change subject: mb/google/poppy/variant/nami: disable unused usb2 ports ......................................................................
Patch Set 2: Code-Review+1
LGTM
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30986 )
Change subject: mb/google/poppy/variant/nami: disable unused usb2 ports ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30986 )
Change subject: mb/google/poppy/variant/nami: disable unused usb2 ports ......................................................................
mb/google/poppy/variant/nami: disable unused usb2 ports
disable unused usb2 ports of bard and ekko skus
BUG=120874946 TEST=build a test firmware and run lsusb to check usb ports
Change-Id: I2ef3cd17ada8b65c96bc80675650905949f235e1 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/30986 Reviewed-by: Vincent Wang vwang@google.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Ren Kuo: Looks good to me, but someone else must approve Vincent Wang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index c656954..8592cae 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -267,6 +267,10 @@ case SKU_2_EKKO: case SKU_3_EKKO: pl2_id = PL2_ID_BARD_EKKO; + cfg->usb2_ports[5].enable = 0; + cfg->usb2_ports[7].enable = 0; + cfg->usb2_ports[8].enable = 0; + cfg->usb2_ports[9].enable = 0; break; default: break;
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Ren Kuo (Code Review)
-
Vincent Wang (Code Review)