Attention is currently required from: Lance Zhao, Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Archana Patni, Michael Niewöhner, Ronak Kanabar.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59790 )
Change subject: mb/google/brya: Fix S0i3 regression
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59790/comment/1a2a8a2b_af6b03df
PS2, Line 8:
When entering S0ix states, when the PM timer is enabled, the system is unable to enter S0i3 (PM time […]
Ack
https://review.coreboot.org/c/coreboot/+/59790/comment/1f531f50_36d7ec3d
PS2, Line 9: ACPI PM timer needs to be disabled explicitly in CB to increment S0i3
: counter as FSP has no control to do the same since
suggestion: […]
Done
https://review.coreboot.org/c/coreboot/+/59790/comment/6882ea1d_34390132
PS2, Line 12:
Please add the tag: […]
Done
https://review.coreboot.org/c/coreboot/+/59790/comment/861cc319_f2f2f7c6
PS2, Line 14: TEST=Boot gimble to OS and verify S0i3 counter incrementing
After exiting S0ix suspend state, […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8005dacd732c033980ccc479375ff5b06df8dac1
Gerrit-Change-Number: 59790
Gerrit-PatchSet: 3
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Archana Patni
archana.patni@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Archana Patni
archana.patni@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 16:21:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment