Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41607 )
Change subject: drivers/intel/mipi_camera: Generate SSDT for camera ......................................................................
Patch Set 19:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41607/17//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41607/17//COMMIT_MSG@21 PS17, Line 21: in to
into
Done
https://review.coreboot.org/c/coreboot/+/41607/17/src/drivers/intel/mipi_cam... File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/41607/17/src/drivers/intel/mipi_cam... PS17, Line 14: {.type = IMGCLK, .index = (ind), .action = (act), .delay_ms = (delay) }
Please add a space after { in the beginning.
This is specific to power resource, will move it to other patch
https://review.coreboot.org/c/coreboot/+/41607/17/src/drivers/intel/mipi_cam... PS17, Line 17: {.type = GPIO, .index = (ind), .action = (act), .delay_ms = (delay) }
Ditto.
This is specific to power resource, will move it to other patch
https://review.coreboot.org/c/coreboot/+/41607/17/src/drivers/intel/mipi_cam... PS17, Line 125: * this is in unit of usec */
The coding style prefer no asterisk for concise multi-line comments. […]
Done
https://review.coreboot.org/c/coreboot/+/41607/17/src/drivers/intel/mipi_cam... PS17, Line 174: uint32_t nvm_readonly;
That sounds like, it should be a boolean?
The final output is going to be int so it was kept as int.
https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/poppy/...
-
Sugnan Prabhu S (Code Review)