Attention is currently required from: Bao Zheng, Martin Roth, Marshall Dawson, Richard Spiegel, Zheng Bao, Matt Papageorge.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58871 )
Change subject: amdfwtool: Call the set_efs_table for Stoneyridge
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
I have not tested on Stoeyridge. But I assume it doesn't break the board. […]
will it be sufficient to see if i get serial console output on a stoneyridge chromebook? i can try that and that will show that the x86 part still starts; if i need to boot into chromeos that would be more difficult
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24499ff6daf7878b12b6044496f53379116c598f
Gerrit-Change-Number: 58871
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 16:50:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Gerrit-MessageType: comment