Change in coreboot[master]: mb/google/dedede/var/sasukette:Add fw_config probe for codec ALC5682I... - coreboot-gerrit

16 Aug 2021


      Attention is currently required from: Zhi7 Li.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette:Add fw_config probe for codec ALC5682I-VD & VS compatibility
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126234):
https://review.coreboot.org/c/coreboot/+/56930/comment/2483546f_a64868e9 
PS8, Line 16: 		{.type = DEVICE_PATH_I2C, .i2c.device = 0x1a}};
space required after that close brace '}'
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 8
Gerrit-Owner: Zhi7 Li lizhi7@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Zhi7 Li lizhi7@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 16 Aug 2021 03:27:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment