Change in ...coreboot[master]: mb/google/poppy/variants/atlas: Add tdp_pl1_override value
Puthikorn Voravootivat has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31627
Change subject: mb/google/poppy/variants/atlas: Add tdp_pl1_override value ......................................................................
mb/google/poppy/variants/atlas: Add tdp_pl1_override value
Use 7w PL1 with DPTF throttle to enable better performance for atlas.
BUG=b:113101335 BRANCH=None TEST=Recommend setting from thermal team. Build coreboot on atlas
Change-Id: Idcf44f213259634a507a013b31b410ed322e9479 Signed-off-by: Puthikorn Voravootivat puthik@chromium.org --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/31627/1
diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 5b49884..380c747 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -62,6 +62,7 @@ register "PmTimerDisabled" = "1"
register "speed_shift_enable" = "1" + register "tdp_pl1_override" = "7" register "tdp_pl2_override" = "15" register "psys_pmax" = "45" register "tcc_offset" = "10"
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31627 )
Change subject: mb/google/poppy/variants/atlas: Add tdp_pl1_override value ......................................................................
Patch Set 1: Code-Review+2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31627 )
Change subject: mb/google/poppy/variants/atlas: Add tdp_pl1_override value ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31627 )
Change subject: mb/google/poppy/variants/atlas: Add tdp_pl1_override value ......................................................................
mb/google/poppy/variants/atlas: Add tdp_pl1_override value
Use 7w PL1 with DPTF throttle to enable better performance for atlas.
BUG=b:113101335 BRANCH=None TEST=Recommend setting from thermal team. Build coreboot on atlas
Change-Id: Idcf44f213259634a507a013b31b410ed322e9479 Signed-off-by: Puthikorn Voravootivat puthik@chromium.org Reviewed-on: https://review.coreboot.org/c/31627 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Caveh Jalali caveh@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Caveh Jalali: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 5b49884..380c747 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -62,6 +62,7 @@ register "PmTimerDisabled" = "1"
register "speed_shift_enable" = "1" + register "tdp_pl1_override" = "7" register "tdp_pl2_override" = "15" register "psys_pmax" = "45" register "tcc_offset" = "10"
-
Caveh Jalali (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Puthikorn Voravootivat (Code Review)