Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu, Yidi Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72749 )
Change subject: mb/google/geralt: Add power on sequence for BOE_TV110C9M_LL0 ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72749/comment/8add608c_3f64d5c6 PS1, Line 7: power on power-on
https://review.coreboot.org/c/coreboot/+/72749/comment/2b2da857_aa52be5d PS1, Line 9: Add power sequence to power on BOE_TV110C9M_LL0 on Geralt proto board. For Geralt, we use BOE_TV110C9M_LL0 as mipi firmware display, so add the power-on sequence for BOE_TV110C9M_LL0.
https://review.coreboot.org/c/coreboot/+/72749/comment/00d9c472_adfcb342 PS1, Line 12: on Geralt proto : board on Geralt.
File src/mainboard/google/geralt/panel_geralt.c:
https://review.coreboot.org/c/coreboot/+/72749/comment/7191e4e7_d4fa49de PS1, Line 22: static int mipi_panel_reg_mask (u8 addr, u8 val, u8 mask) move to panel.c.
https://review.coreboot.org/c/coreboot/+/72749/comment/3c08bda8_bea6a578 PS1, Line 26: if (i2c_read_field(MIPI_PANEL_I2C, MIPI_PANEL_SLAVE, addr, &msg, 0xFF, 0)) : printk(BIOS_ERR, "Rex: failed to read i2c: %d\n", addr); ` if (i2c_read_field(MIPI_PANEL_I2C, MIPI_PANEL_SLAVE, addr, &msg, 0xFF, 0)) { printk(BIOS_ERR, "Failed to read i2c: %d\n", addr); return -1; } `
https://review.coreboot.org/c/coreboot/+/72749/comment/c20e2189_093937b9 PS1, Line 66: ret = mipi_panel_reg_mask(0x00, 0x11, 0x1F); : : /* Set AVEE = -5.7V */ : ret = mipi_panel_reg_mask(0x01, 0x11, 0x1F); : : /* Disable AVDD & AVEE discharge when power on*/ : ret = mipi_panel_reg_mask(0x03, 0x30, 0xFF); do some error handling