Attention is currently required from: Angel Pons, Kyösti Mälkki, Felix Held.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74369 )
Change subject: mb/purism/librem_cnl: Configure SuperIO for Librem Mini v1/v2
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74369/comment/24dcbc5a_d13d0849
PS4, Line 17: open and BRAM bank 1 is accessible.
LPC I/O range happens later with CB:74363.
CB:74363 is just the one for early bootblock to support cmos.default. Adding the I/O range to the device tree also enables the LPC I/O range (later in ramstage) so BRAM1 is now accessible from the OS.
(It doesn't duplicate either, when the device tree I/O ranges are opened it checks if the range is already opened earlier.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74369
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58a5a427737f4a2caa64326c110eb53ec00b347d
Gerrit-Change-Number: 74369
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 May 2023 17:56:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment