[M] Change in coreboot[master]: mb/google/brya/variants/hades: Update GPU power sequencing to add Had... - coreboot-gerrit

6 Apr 2023


      Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73896 )
Change subject: mb/google/brya/variants/hades: Update GPU power sequencing to add Hades support
......................................................................
Patch Set 22:
(1 comment)
File src/mainboard/google/brya/variants/hades/variant.c:
https://review.coreboot.org/c/coreboot/+/73896/comment/1d09922d_833919c7 
PS22, Line 148: void variant_fill_ssdt(const struct device *dev)
Since we have power.asl, why just put the _INI into it? It'd better all C code or all ASL code.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b8efe7a34102cf61d4f784103c4a4f9337213f7
Gerrit-Change-Number: 73896
Gerrit-PatchSet: 22
Gerrit-Owner: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 15:09:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment