HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39399 )
Change subject: [Test] test some gcc's Warning-Options ......................................................................
[Test] test some gcc's Warning-Options
Change-Id: I189eb1aae2ab9aa6dce3fa5121dc503ca8bd5e9a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/39399/1
diff --git a/Makefile.inc b/Makefile.inc index f172005..b56f4ce 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -419,6 +419,8 @@
CFLAGS_common += -pipe -g -nostdinc -std=gnu11 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes +CFLAGS_common += -Wlogical-op -Wmisleading-indentation -Wduplicated-branches -Wduplicated-cond +CFLAGS_common += -Wunused-macros -Wconversion -Wdangling-else -Wdisabled-optimization CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits -Wvla CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39399 )
Change subject: [Test] test some gcc's Warning-Options ......................................................................
Patch Set 1:
Maybe we want to enable these one at a time in independent patches and start working on them?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39399 )
Change subject: [Test] test some gcc's Warning-Options ......................................................................
Patch Set 1:
Patch Set 1:
Maybe we want to enable these one at a time in independent patches and start working on them?
maybe '-Wconversion' flag? the others seems to be ok
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39399 )
Change subject: [Test] test some gcc's Warning-Options ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Maybe we want to enable these one at a time in independent patches and start working on them?
maybe '-Wconversion' flag? the others seems to be ok
I think the -Wconversion might just be the first one to fail, but absolutely, that'd be a good one to separate out so we can test the others.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39399 )
Change subject: [Test] test some gcc's Warning-Options ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)