Attention is currently required from: Felix Singer, Idwer Vollering, Martin L Roth.
Jérémy Compostella has posted comments on this change by Idwer Vollering. ( https://review.coreboot.org/c/coreboot/+/84807?usp=email )
Change subject: build system: define and use an OS-specific sed ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: I found other occurrences where sed is being used, shouldn't they also be addressed ?
``` ./payloads/external/depthcharge/Makefile ./payloads/external/edk2/Makefile ./payloads/external/iPXE/Makefile ./payloads/external/SeaBIOS/seabios/scripts/kconfig/Makefile ./payloads/libpayload/curses/PDCurses/Makefile.in ./payloads/libpayload/Makefile.mk ./src/arch/arm64/Makefile.mk ./src/commonlib/storage/Makefile.mk ./src/lib/Makefile.mk ./src/sbom/Makefile.mk ./src/soc/amd/common/Makefile.mk ./src/soc/intel/baytrail/Makefile.mk ./src/soc/intel/broadwell/Makefile.mk ./src/soc/intel/common/block/fast_spi/Makefile.mk ./src/vendorcode/amd/opensil/Makefile.mk ./util/cbfstool/lz4/lib/Makefile ./util/docker/Makefile ./util/kconfig/Makefile.mk ./util/nvidia/cbootimage/src/Makefile.am ```
Note: In addition, some third party projects want to take advantage of it.
``` ./3rdparty/arm-trusted-firmware/Makefile ./3rdparty/ffs/ffs/test/Makefile ./3rdparty/libgfxinit/common/Makefile.inc ./3rdparty/libhwbase/common/Makefile.inc ./3rdparty/libhwbase/Makefile ./3rdparty/libhwbase/Makefile.proof ./3rdparty/open-power-signing-utils/Makefile.am ./3rdparty/opensbi/Makefile ./3rdparty/stm/Stm/StmPkg/EdkII/BaseTools/Makefile ./3rdparty/stm/Stm/StmPkg/EdkII/BaseTools/Source/C/Common/Makefile ./3rdparty/stm/Stm/StmPkg/EdkII/BaseTools/Source/C/Makefile ./3rdparty/stm/Stm/StmPkg/EdkII/BaseTools/Source/Python/Makefile ./3rdparty/vboot/Makefile ```
-
Jérémy Compostella (Code Review)