Change in coreboot[master]: hatch: Enable EC sync in romstage

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Tim Wawrzynczak (Code Review)

20 Nov 2019 20 Nov '19

11:38 a.m.

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37025 )

Change subject: hatch: Enable EC sync in romstage ......................................................................

hatch: Enable EC sync in romstage

Now that the EC software sync in romstage ("early EC sync") patches have landed, it's time to enable this for Hatch.

BUG=none BRANCH=hatch TEST=verify EC sync runs in romstage

Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/37025/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 943ec61..19319d2 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -22,6 +22,7 @@ select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE select SOC_INTEL_COMETLAKE select SYSTEM_TYPE_LAPTOP + select VBOOT_EARLY_EC_SYNC

if BOARD_GOOGLE_BASEBOARD_HATCH

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Aaron Durbin (Code Review)

20 Nov 20 Nov

11:39 a.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37025 )

Change subject: hatch: Enable EC sync in romstage ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37025/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37025/1//COMMIT_MSG@12 PS1, Line 12: none really?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Wed, 20 Nov 2019 19:39:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

11:44 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37025 )

Change subject: hatch: Enable EC sync in romstage ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37025/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37025/1//COMMIT_MSG@12 PS1, Line 12: none

...

really?

You caught me

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Wed, 20 Nov 2019 19:44:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

11:44 a.m.

Hello Shelley Chen, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37025

to look at the new patch set (#2).

Change subject: hatch: Enable EC sync in romstage ......................................................................

hatch: Enable EC sync in romstage

Now that the EC software sync in romstage ("early EC sync") patches have landed, it's time to enable this for Hatch.

BUG=b:144853307 BRANCH=hatch TEST=verify EC sync runs in romstage

Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/37025/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

22 Nov 22 Nov

1:40 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37025 )

Change subject: hatch: Enable EC sync in romstage ......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/37025/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/c/coreboot/+/37025/3/src/mainboard/google/hatch/... PS3, Line 25: VBOOT_EARLY_EC_SYNC nit: Should this go under "config VBOOT" on line 130?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Fri, 22 Nov 2019 21:40:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

1:43 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37025 )

Change subject: hatch: Enable EC sync in romstage ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37025/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/c/coreboot/+/37025/3/src/mainboard/google/hatch/... PS3, Line 25: VBOOT_EARLY_EC_SYNC

...

nit: Should this go under "config VBOOT" on line 130?

Gee that makes sense :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Fri, 22 Nov 2019 21:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

1:45 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37025

to look at the new patch set (#4).

Change subject: hatch: Enable EC sync in romstage ......................................................................

hatch: Enable EC sync in romstage

Now that the EC software sync in romstage ("early EC sync") patches have landed, it's time to enable this for Hatch.

BUG=none BRANCH=hatch TEST=verify EC sync runs in romstage

Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/37025/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

1:50 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37025 )

Change subject: hatch: Enable EC sync in romstage ......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/37025/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/c/coreboot/+/37025/4/src/mainboard/google/hatch/... PS4, Line 135: nit: extra blank line :P

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Fri, 22 Nov 2019 21:50:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

1:53 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37025

to look at the new patch set (#5).

Change subject: hatch: Enable EC sync in romstage ......................................................................

hatch: Enable EC sync in romstage

Now that the EC software sync in romstage ("early EC sync") patches have landed, it's time to enable this for Hatch.

BUG=none BRANCH=hatch TEST=verify EC sync runs in romstage

Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/37025/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

1:56 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37025 )

Change subject: hatch: Enable EC sync in romstage ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Fri, 22 Nov 2019 21:56:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

24 Nov 24 Nov

2:14 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37025 )

Change subject: hatch: Enable EC sync in romstage ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37025/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/c/coreboot/+/37025/4/src/mainboard/google/hatch/... PS4, Line 135:

...

nit: extra blank line :P

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Sun, 24 Nov 2019 22:14:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

25 Nov 25 Nov

1:20 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37025 )

Change subject: hatch: Enable EC sync in romstage ......................................................................

hatch: Enable EC sync in romstage

Now that the EC software sync in romstage ("early EC sync") patches have landed, it's time to enable this for Hatch.

BUG=none BRANCH=hatch TEST=verify EC sync runs in romstage

Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/37025 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 943ec61..d6e6e46 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -129,6 +129,7 @@ config VBOOT select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN + select VBOOT_EARLY_EC_SYNC select VBOOT_LID_SWITCH

endif # BOARD_GOOGLE_BASEBOARD_HATCH

-- To view, visit https://review.coreboot.org/c/coreboot/+/37025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie567ab081b95b2302b051812fbf46e183c76bab6 Gerrit-Change-Number: 37025 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: merged

1818

days inactive

1823

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

Aaron Durbin (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Tim Wawrzynczak (Code Review)