Attention is currently required from: Xi Chen, Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64861 )
Change subject: soc/mediatek: Enable thermal hardware reset for MT8192 and MT8195
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/mt8192/bootblock.c:
https://review.coreboot.org/c/coreboot/+/64861/comment/0130c732_02c178b0
PS1, Line 14: mtk_wdt_preinit();
What about move this function call to mtk_wdt_init() and create a weak function like what mtk_wdt_cl […]
I have thought that for MT8186, but I think the function name "preinit" should be put before "mtk_wdt_init"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64861
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d
Gerrit-Change-Number: 64861
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 13:13:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@chromium.org
Gerrit-MessageType: comment