Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19043 )
Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/ptn346... File src/mainboard/siemens/mc_apl1/ptn3460.c:
PS1, Line 106: (i = 0;
It seems like it would be easy to provide one. Have you tried that?
Sure but we should think about an i2c_write_bytes function if we made a separate driver for the PTN.
https://review.coreboot.org/#/c/19043/3/src/mainboard/siemens/mc_apl1/ptn346... File src/mainboard/siemens/mc_apl1/ptn3460.c:
PS3, Line 35: PTN_
There's not a constant defined for edid size anywhere? You seem to have def
Changed it to PTN_EDID_LEN
PS3, Line 50: s
sizeof(disp_con)
Changed both sides of comparsion to sizeof(disp_con).
PS3, Line 55:
sizeof(color_depth)
Done
PS3, Line 75: (cfg))
i2c_read_bytes() doesn't return CB_* return codes explicitly. You probably
I changed it back to the previous version because of the distinction of the different error messages.
PS3, Line 126:
should be const u8 *.
changed
-
Mario Scheithauer (Code Review)