Attention is currently required from: Raul Rangel, Jason Nien, EricKY Cheng, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Martin Roth, Moises Garcia, Eric Peers, Karthik Ramasubramanian.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67793 )
Change subject: ec/google/chromec: Host event support of DTTS
......................................................................
Patch Set 11:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67793/comment/cc37ece4_9eca61c9
PS4, Line 7: evet
typo
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/67793/comment/4077662d_fc321966
PS11, Line 7: ec/google/chromec: Host event support of DTTS
nit: This CL is adding DPTC calls to specific host events. To be more accurate, I'd update this to use the line in the description:
Add DPTC support for host event 1/2/9
https://review.coreboot.org/c/coreboot/+/67793/comment/10b80ba1_963128bf
PS11, Line 10: 29
Event 29 is not handled by this CL.
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/67793/comment/09fe2197_3917a8a3
PS8, Line 59:
whitespace: use a tab, rather than spaces, to match the other lines.
Done
https://review.coreboot.org/c/coreboot/+/67793/comment/50393b77_b9195f91
PS8, Line 60: tempture
typo
Done
https://review.coreboot.org/c/coreboot/+/67793/comment/cb3c2577_21a45d79
PS8, Line 59: RSV1, 1, // Reserved bit
: STTT, 1, // Switch thermal table by tempture(bit 5)
: STTB, 1, // Switch thermal table by body detection(bit 6)
Please move this change into a separate CL that describes what they are used for.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67793
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I156a9d138ccac7f75cc0dd0d827f7a721fcbc782
Gerrit-Change-Number: 67793
Gerrit-PatchSet: 11
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Moises Garcia
moisesgarcia@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Moises Garcia
moisesgarcia@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 22:11:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment