Attention is currently required from: Robert Zieba, Bao Zheng, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 )
Change subject: util/amdfwtool: Add amdfwread utility
......................................................................
Patch Set 10: Code-Review+1
(5 comments)
File util/amdfwtool/Makefile:
https://review.coreboot.org/c/coreboot/+/62795/comment/7a1f2384_d759f965
PS10, Line 21: HEADER
This doesn't look like it's defined.
File util/amdfwtool/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/62795/comment/27e49a97_88dd6746
PS10, Line 15: begging
beginning?
https://review.coreboot.org/c/coreboot/+/62795/comment/b7ca5242_97f414b7
PS10, Line 122: current_entries
clang-format
https://review.coreboot.org/c/coreboot/+/62795/comment/268fc2f5_98be8592
PS10, Line 141: current_entries
clang-format
https://review.coreboot.org/c/coreboot/+/62795/comment/84e864ce_a5047345
PS10, Line 153: current_entries
clang-format
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850
Gerrit-Change-Number: 62795
Gerrit-PatchSet: 10
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 03 May 2022 16:09:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment