Change in coreboot[master]: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table

[Alex Levin (Code Review)]

Alex Levin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table

BT_DISABLE_L (GPP_A13) has to asserted in early_gpio_table to reset
bluetooth on reset.

BUG=b:171085081
TEST=volteer2 boots; scope shows assertion of the signal

Change-Id: Iaa5799e9cab69c074b7920604c8a6c85ad07358a
---
M src/mainboard/google/volteer/variants/baseboard/gpio.c
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/48518/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c
index 5d367e7..47e6d65 100644
--- a/src/mainboard/google/volteer/variants/baseboard/gpio.c
+++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c
@@ -400,7 +400,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
-
+        /* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+        PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48518/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48518/1//COMMIT_MSG@13 
PS1, Line 13: scope shows assertion of the signal
Are there any timing requirements for how long to hold the pin in reset?

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
PS1, Line 405: GPP_A13
This will drive it low.  Does the PAD_CFG_NC initialization of the pin (how the gpio is configured in baseboard's gpio_table) drive it back high?  In some cases, like volteer2, it will drive it back high as volteer2 has GPP_A13 defined as output and driven high in it's override gpio_table.

Note that this change will need to be added to all gpio.c files in volteer/variants/<variant_name>/ that override the baseboard's early gpio table due to the fact that the early gpio table is a full override as it does not mix settings with baseboard settings. unlike the gpio_table above, which mixes the two tables with individual GPIO settings in the table in this file overriding the other where common).

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
PS1, Line 403:         /* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
PS1, Line 405:         PAD_CFG_GPO(GPP_A13, 0, DEEP),
code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
PS1, Line 405:         PAD_CFG_GPO(GPP_A13, 0, DEEP),
please, no spaces at the start of a line

[Alex Levin (Code Review)]

Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48518/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48518/1//COMMIT_MSG@13 
PS1, Line 13: scope shows assertion of the signal
> Are there any timing requirements for how long to hold the pin in reset?

no. see the bug for a detailed discussion

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
PS1, Line 405: GPP_A13
> This will drive it low. […]

Nick, please read the bug for the background. The intent is to drive 0 and later to drive 1.

I have made sure that all the variant indeed drive 1 in ram stage.

[Alex Levin (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48518

to look at the new patch set (#2).

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table

BT_DISABLE_L (GPP_A13) has to asserted in early_gpio_table to reset
bluetooth on reset.

BUG=b:171085081
TEST=volteer2 boots; scope shows assertion of the signal

Change-Id: Iaa5799e9cab69c074b7920604c8a6c85ad07358a
---
M src/mainboard/google/volteer/variants/baseboard/gpio.c
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/48518/2

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48518/2/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/48518/2/src/mainboard/google/voltee... 
PS2, Line 405:         PAD_CFG_GPO(GPP_A13, 0, DEEP),
code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/48518/2/src/mainboard/google/voltee... 
PS2, Line 405:         PAD_CFG_GPO(GPP_A13, 0, DEEP),
please, no spaces at the start of a line

[Alex Levin (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48518

to look at the new patch set (#3).

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table

BT_DISABLE_L (GPP_A13) has to asserted in early_gpio_table to reset
bluetooth on reset.

BUG=b:171085081
TEST=volteer2 boots; scope shows assertion of the signal

Change-Id: Iaa5799e9cab69c074b7920604c8a6c85ad07358a
---
M src/mainboard/google/volteer/variants/baseboard/gpio.c
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/48518/3

[Alex Levin (Code Review)]

Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48518/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48518/1//COMMIT_MSG@13 
PS1, Line 13: scope shows assertion of the signal
> no. […]

sorry, to be more specific, there is a >150ms requirement that is satisfied by toggling this in bootblock and ramstage.

[Alex Levin (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48518

to look at the new patch set (#4).

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table

BT_DISABLE_L (GPP_A13) has to asserted in early_gpio_table to reset
bluetooth on reset.

BUG=b:171085081
TEST=volteer2 boots; scope shows assertion of the signal

Change-Id: Iaa5799e9cab69c074b7920604c8a6c85ad07358a
Signed-off-by: Alex Levin 
---
M src/mainboard/google/volteer/variants/baseboard/gpio.c
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/48518/4

[Alex Levin (Code Review)]

Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... 
PS1, Line 405: GPP_A13
> Nick, please read the bug for the background. The intent is to drive 0 and later to drive 1. […]

ah, re-reading this now. I guess, I have to re-do this for each of the gpio.c files. thanks for pointing this out.

[Alex Levin (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48518

to look at the new patch set (#5).

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table

BT_DISABLE_L (GPP_A13) has to asserted in early_gpio_table to reset
bluetooth on reset.

BUG=b:171085081
TEST=volteer2 boots; scope shows assertion of the signal

Change-Id: Iaa5799e9cab69c074b7920604c8a6c85ad07358a
Signed-off-by: Alex Levin 
---
M src/mainboard/google/volteer/variants/baseboard/gpio.c
M src/mainboard/google/volteer/variants/delbin/gpio.c
M src/mainboard/google/volteer/variants/eldrid/gpio.c
M src/mainboard/google/volteer/variants/elemi/gpio.c
M src/mainboard/google/volteer/variants/halvor/gpio.c
M src/mainboard/google/volteer/variants/lindar/gpio.c
M src/mainboard/google/volteer/variants/malefor/gpio.c
M src/mainboard/google/volteer/variants/terrador/gpio.c
M src/mainboard/google/volteer/variants/todor/gpio.c
M src/mainboard/google/volteer/variants/voema/gpio.c
M src/mainboard/google/volteer/variants/volteer/gpio.c
M src/mainboard/google/volteer/variants/volteer2/gpio.c
M src/mainboard/google/volteer/variants/voxel/gpio.c
13 files changed, 39 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/48518/5

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 5: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 5: Code-Review+2

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 5: Code-Review+2

[Nick Vaccaro (Code Review)]

Nick Vaccaro has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Removed Code-Review+2 by Nick Vaccaro

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 5: Code-Review+2

[Alex Levin (Code Review)]

Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48518/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48518/1//COMMIT_MSG@13 
PS1, Line 13: scope shows assertion of the signal
> sorry, to be more specific, there is a >150ms requirement that is satisfied by toggling this in boot […]

Ack

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48518 )

Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table
......................................................................

mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table

BT_DISABLE_L (GPP_A13) has to asserted in early_gpio_table to reset
bluetooth on reset.

BUG=b:171085081
TEST=volteer2 boots; scope shows assertion of the signal

Change-Id: Iaa5799e9cab69c074b7920604c8a6c85ad07358a
Signed-off-by: Alex Levin 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48518
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Nick Vaccaro 
---
M src/mainboard/google/volteer/variants/baseboard/gpio.c
M src/mainboard/google/volteer/variants/delbin/gpio.c
M src/mainboard/google/volteer/variants/eldrid/gpio.c
M src/mainboard/google/volteer/variants/elemi/gpio.c
M src/mainboard/google/volteer/variants/halvor/gpio.c
M src/mainboard/google/volteer/variants/lindar/gpio.c
M src/mainboard/google/volteer/variants/malefor/gpio.c
M src/mainboard/google/volteer/variants/terrador/gpio.c
M src/mainboard/google/volteer/variants/todor/gpio.c
M src/mainboard/google/volteer/variants/voema/gpio.c
M src/mainboard/google/volteer/variants/volteer/gpio.c
M src/mainboard/google/volteer/variants/volteer2/gpio.c
M src/mainboard/google/volteer/variants/voxel/gpio.c
13 files changed, 39 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Nick Vaccaro: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c
index 5d367e7..922d3d1 100644
--- a/src/mainboard/google/volteer/variants/baseboard/gpio.c
+++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c
@@ -400,7 +400,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
-
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/delbin/gpio.c b/src/mainboard/google/volteer/variants/delbin/gpio.c
index bebf38f..5571ee8 100644
--- a/src/mainboard/google/volteer/variants/delbin/gpio.c
+++ b/src/mainboard/google/volteer/variants/delbin/gpio.c
@@ -127,6 +127,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/eldrid/gpio.c b/src/mainboard/google/volteer/variants/eldrid/gpio.c
index 24f80a0..e92f6b1 100644
--- a/src/mainboard/google/volteer/variants/eldrid/gpio.c
+++ b/src/mainboard/google/volteer/variants/eldrid/gpio.c
@@ -166,6 +166,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/elemi/gpio.c b/src/mainboard/google/volteer/variants/elemi/gpio.c
index b86202b..ecb3c19 100644
--- a/src/mainboard/google/volteer/variants/elemi/gpio.c
+++ b/src/mainboard/google/volteer/variants/elemi/gpio.c
@@ -180,6 +180,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),
    /* B2  : VRALERT# ==> EN_PP3300_SSD */
diff --git a/src/mainboard/google/volteer/variants/halvor/gpio.c b/src/mainboard/google/volteer/variants/halvor/gpio.c
index 8b5a192..378c150 100644
--- a/src/mainboard/google/volteer/variants/halvor/gpio.c
+++ b/src/mainboard/google/volteer/variants/halvor/gpio.c
@@ -198,7 +198,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
-
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/lindar/gpio.c b/src/mainboard/google/volteer/variants/lindar/gpio.c
index 7b5184d..1d3d693 100644
--- a/src/mainboard/google/volteer/variants/lindar/gpio.c
+++ b/src/mainboard/google/volteer/variants/lindar/gpio.c
@@ -109,6 +109,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),
    /* A22 : DDPC_CTRLDATA ==> EN_PP3300_SSD */
diff --git a/src/mainboard/google/volteer/variants/malefor/gpio.c b/src/mainboard/google/volteer/variants/malefor/gpio.c
index 90ad354..2498981 100644
--- a/src/mainboard/google/volteer/variants/malefor/gpio.c
+++ b/src/mainboard/google/volteer/variants/malefor/gpio.c
@@ -155,7 +155,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
-
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/terrador/gpio.c b/src/mainboard/google/volteer/variants/terrador/gpio.c
index a0267cc..d5498d0 100644
--- a/src/mainboard/google/volteer/variants/terrador/gpio.c
+++ b/src/mainboard/google/volteer/variants/terrador/gpio.c
@@ -189,6 +189,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/todor/gpio.c b/src/mainboard/google/volteer/variants/todor/gpio.c
index f202543..40d25a5 100644
--- a/src/mainboard/google/volteer/variants/todor/gpio.c
+++ b/src/mainboard/google/volteer/variants/todor/gpio.c
@@ -197,6 +197,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/voema/gpio.c b/src/mainboard/google/volteer/variants/voema/gpio.c
index 267ce10..d905dae 100644
--- a/src/mainboard/google/volteer/variants/voema/gpio.c
+++ b/src/mainboard/google/volteer/variants/voema/gpio.c
@@ -187,6 +187,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/volteer/gpio.c b/src/mainboard/google/volteer/variants/volteer/gpio.c
index 1077fa1..0d230fd 100644
--- a/src/mainboard/google/volteer/variants/volteer/gpio.c
+++ b/src/mainboard/google/volteer/variants/volteer/gpio.c
@@ -210,6 +210,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/volteer2/gpio.c b/src/mainboard/google/volteer/variants/volteer2/gpio.c
index 5c10ec5..cfd9e8b 100644
--- a/src/mainboard/google/volteer/variants/volteer2/gpio.c
+++ b/src/mainboard/google/volteer/variants/volteer2/gpio.c
@@ -212,6 +212,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),

diff --git a/src/mainboard/google/volteer/variants/voxel/gpio.c b/src/mainboard/google/volteer/variants/voxel/gpio.c
index 6e5fc0b..d6df489 100644
--- a/src/mainboard/google/volteer/variants/voxel/gpio.c
+++ b/src/mainboard/google/volteer/variants/voxel/gpio.c
@@ -239,6 +239,9 @@
 static const struct pad_config early_gpio_table[] = {
    /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */
    PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
+	/* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */
+	/* assert reset on reboot */
+	PAD_CFG_GPO(GPP_A13, 0, DEEP),
    /* A17 : DDSP_HPDC ==> MEM_CH_SEL */
    PAD_CFG_GPI(GPP_A17, NONE, DEEP),