Attention is currently required from: Ravi kumar, Furquan Shaikh, Paul Menzel, Ravi Kumar Bokka, Julius Werner, Prasad Malisetty, mturney mturney.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe host controller driver
......................................................................
Patch Set 66:
(2 comments)
Patchset:
PS66:
I don't see any changes to src/soc/qualcomm/sc7280/Kconfig, as mentioned in: https://review.coreboot.org/c/coreboot/+/58668/4/src/soc/qualcomm/sc7280/Kco...
You need to add PCI (because you are using PCI support) and you need to set NO_ECAM_MMCONF_SUPPORT because you are not using ECAM. Once you set those Kconfigs, you'll start to see compilation errors due to pci_map_bus not being defined. This should be your atu mapping function that you defined in pcie_host.c.
File src/soc/qualcomm/sc7280/pcie_host.c:
https://review.coreboot.org/c/coreboot/+/53902/comment/9d4d3c3a_f803c708
PS66, Line 367: qcom_dw_pcie_prog_outbound_atu
This is the main address mapping function, correct? Then this needs to be renamed pci_map_bus (or create a wrapper around this), as that needs to be defined if you are not using the ECAM method. The function prototype is defined in pci_mmio_cfg.h:
volatile union pci_bank *pci_map_bus(pci_devfn_t dev);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccf60aa56541f5230fa9c3f821d7709615c36631
Gerrit-Change-Number: 53902
Gerrit-PatchSet: 66
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 01 Mar 2022 06:35:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment