Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58368 )
Change subject: mb/prodrive/hermes: Map PCIe clocks to root ports
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/prodrive/hermes/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/58368/comment/b31d606e_7d85d1a2
PS2, Line 30: register "PcieClkSrcUsage[0]" = "20" # PCIe Slot1
might be good to have defines or depending on what this actually does an enum in the soc code for those magic values. i'd also avoid mixing decimal numbers and hex numbers for different elements of the same array. feel free to ack this one and address it in a follow-up patch though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0515877a36d42fb8858a0f0b3c0af1199a18d9af
Gerrit-Change-Number: 58368
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 29 Oct 2021 14:22:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment