build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35004 )
Change subject: x86: Introduce RESET_VECTOR_IN_RAM option
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35004/5/src/include/rules.h
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/35004/5/src/include/rules.h@274
PS5, Line 274: #define ENV_STAGE_HAS_DATA_SECTION (!ENV_ROMSTAGE_OR_BEFORE || CONFIG(RESET_VECTOR_IN_RAM))
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I098ecf8bf200550db1e15f178f7661c1ac516dc5
Gerrit-Change-Number: 35004
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Aug 2019 12:21:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment