Change in coreboot[master]: mb/google/hatch/var/kindred: set wifi sar for kled

[David Wu (Code Review)]

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39813 )

Change subject: mb/google/hatch/var/kindred: set wifi sar for kled
......................................................................

mb/google/hatch/var/kindred: set wifi sar for kled

Enable wifi sar feature and set wifi sar name for kled sku.

BUG=b:152277272
TEST=emerge-hatch coreboot chromeos-bootimage and
     verify wifi SAR load by sku-id

Change-Id: I9ee242773fd05cc2bcd7bde07da8176022827677
Signed-off-by: David Wu 
---
M src/mainboard/google/hatch/variants/kindred/variant.c
1 file changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/39813/1

diff --git a/src/mainboard/google/hatch/variants/kindred/variant.c b/src/mainboard/google/hatch/variants/kindred/variant.c
index 72bed92..ce9df8a 100644
--- a/src/mainboard/google/hatch/variants/kindred/variant.c
+++ b/src/mainboard/google/hatch/variants/kindred/variant.c
@@ -16,6 +16,7 @@
 #include <chip.h>
 #include <soc/pci_devs.h>
 #include <ec/google/chromeec/ec.h>
+#include <sar.h>

void variant_devtree_update(void)
 {
@@ -46,3 +47,13 @@
    	cfg->satapwroptimize = 0;
    }
 }
+
+const char *get_wifi_sar_cbfs_filename(void)
+{
+	const char *filename = NULL;
+	uint32_t sku_id = google_chromeec_get_board_sku();
+
+	if (sku_id == 1 || sku_id == 2 || sku_id == 3 || sku_id == 4)
+		filename = "wifi_sar-kled.hex";
+	return filename;
+}

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39813 )

Change subject: mb/google/hatch/var/kindred: set wifi sar for kled
......................................................................

Patch Set 1:

This isn't necessary, the ebuilds will automatically rename the file to wifi_sar-default.hex, and the SAR code will pull that in.

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39813 )

Change subject: mb/google/hatch/var/kindred: set wifi sar for kled
......................................................................

Patch Set 1: Code-Review+2

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39813 )

Change subject: mb/google/hatch/var/kindred: set wifi sar for kled
......................................................................

Patch Set 1:
> Patch Set 1:
>
> This isn't necessary, the ebuilds will automatically rename the file to wifi_sar-default.hex, and the SAR code will pull that in.

Kindred shares the same code, just different SKUs, and we don't want this on Kindred.

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39813 )

Change subject: mb/google/hatch/var/kindred: set wifi sar for kled
......................................................................

mb/google/hatch/var/kindred: set wifi sar for kled

Enable wifi sar feature and set wifi sar name for kled sku.

BUG=b:152277272
TEST=emerge-hatch coreboot chromeos-bootimage and
     verify wifi SAR load by sku-id

Change-Id: I9ee242773fd05cc2bcd7bde07da8176022827677
Signed-off-by: David Wu 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39813
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Fagerburg 
---
M src/mainboard/google/hatch/variants/kindred/variant.c
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/kindred/variant.c b/src/mainboard/google/hatch/variants/kindred/variant.c
index 72bed92..ce9df8a 100644
--- a/src/mainboard/google/hatch/variants/kindred/variant.c
+++ b/src/mainboard/google/hatch/variants/kindred/variant.c
@@ -16,6 +16,7 @@
 #include <chip.h>
 #include <soc/pci_devs.h>
 #include <ec/google/chromeec/ec.h>
+#include <sar.h>

void variant_devtree_update(void)
 {
@@ -46,3 +47,13 @@
    	cfg->satapwroptimize = 0;
    }
 }
+
+const char *get_wifi_sar_cbfs_filename(void)
+{
+	const char *filename = NULL;
+	uint32_t sku_id = google_chromeec_get_board_sku();
+
+	if (sku_id == 1 || sku_id == 2 || sku_id == 3 || sku_id == 4)
+		filename = "wifi_sar-kled.hex";
+	return filename;
+}