Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55160 )
Change subject: [WIP]amdfwtool: Add a script to replace AMD firmware ......................................................................
Patch Set 3:
(4 comments)
File util/amdfwtool/replace.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120677): https://review.coreboot.org/c/coreboot/+/55160/comment/18fc600f_6045565c PS3, Line 12: CBFS_ADDRESS=$(eval $CBFSTOOL $IMAGE layout | grep "^'COREBOOT'" | sed "s/'COREBOOT' (CBFS, size [0-9]+, offset ([0-9]+))/\1/g") line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120677): https://review.coreboot.org/c/coreboot/+/55160/comment/402e0db2_617b2736 PS3, Line 15: AMDFW_ADDRESS=0x$(eval printf %x $(eval expr 4294967295 + 1 - $(($ROMSIZE)) + $CBFS_ADDRESS + $AMDFW_OFFSET + 64)) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120677): https://review.coreboot.org/c/coreboot/+/55160/comment/c6d5b3f6_9f797dda PS3, Line 72: --instance 0 --apcb BiosDirL20_Typex60.bin --instance 10 --apcb BiosDirL20_Typex68.bin --apob-base 0x2001000 --bios-bin $BIOS_BIN_FILE --bios-bin-dest $BIOS_BIN_DEST --bios-uncomp-size $BIOS_BIN_SIZE --soft-fuse $SOFT_FUSE --use-pspsecureos --load-s0i3 --combo-capable "--token-unlock" --spi-read-mode 2 --spi-speed 0 --spi-micron-flag 0 --config "fw.cfg" --soc-name "Cezanne" --flashsize $ROMSIZE \ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120677): https://review.coreboot.org/c/coreboot/+/55160/comment/12758b42_c8fe135f PS3, Line 84: $CBFSTOOL $IMAGE_NEW add -f amdfw_n.rom -n apu/amdfw -t raw -r COREBOOT -b $(($AMDFW_ADDRESS)) line over 96 characters
-
build bot (Jenkins) (Code Review)