Change in coreboot[master]: Signed-off-by: himanshu sahdev aka CunningLearner <sahdev.himan@gmail...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HIMANSHU SAHDEV (Code Review)

20 Jul 2019 20 Jul '19

1:55 p.m.

HIMANSHU SAHDEV has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: Signed-off-by: himanshu sahdev aka CunningLearner sahdev.himan@gmail.com ......................................................................

Signed-off-by: himanshu sahdev aka CunningLearner sahdev.himan@gmail.com

payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile

Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 --- M payloads/libpayload/sample/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/1

diff --git a/payloads/libpayload/sample/Makefile b/payloads/libpayload/sample/Makefile index 5931d5e..5b55710 100644 --- a/payloads/libpayload/sample/Makefile +++ b/payloads/libpayload/sample/Makefile @@ -37,7 +37,7 @@

CC := $(CC_$(ARCH-y)) AS := $(AS_$(ARCH-y)) -LIBPAYLOAD_DIR := ../install/libpayload +LIBPAYLOAD_DIR := .. XCC := CC="$(CC)" $(LIBPAYLOAD_DIR)/bin/lpgcc XAS := AS="$(AS)" $(LIBPAYLOAD_DIR)/bin/lpas CFLAGS := -Wall -Werror -Os

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

HIMANSHU SAHDEV (Code Review)

20 Jul 20 Jul

2:08 p.m.

HIMANSHU SAHDEV has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: Signed-off-by: himanshu sahdev aka CunningLearner sahdev.himan@gmail.com ......................................................................

Patch Set 1:

Hello, I am newbie and this is just my start with coreboot and I wanted to learn a lot with the upcoming feedback. I would be happy to have you as a mentor. Thanks for your time and support.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 1 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 20 Jul 2019 14:08:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HIMANSHU SAHDEV (Code Review)

2:13 p.m.

New subject: Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

Hello Julius Werner, build bot (Jenkins), Raul Rangel, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34460

to look at the new patch set (#2).

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile

This CL allows building a sample libpayload.

Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Signed-off-by: himanshu sahdev aka CunningLearner sahdev.himan@gmail.com --- M payloads/libpayload/sample/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 2 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HIMANSHU SAHDEV (Code Review)

29 Jul 29 Jul

4:54 p.m.

New subject: Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

HIMANSHU SAHDEV has removed Raul Rangel from this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Removed reviewer Raul Rangel.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 2 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Name of user not set #1002508 Gerrit-CC: PraveenX Hodagatta Pranesh praveenx.hodagatta.pranesh@intel.com Gerrit-MessageType: deleteReviewer

HIMANSHU SAHDEV (Code Review)

4:54 p.m.

New subject: Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

HIMANSHU SAHDEV has removed Julius Werner from this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Removed reviewer Julius Werner.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 2 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Name of user not set #1002508 Gerrit-CC: PraveenX Hodagatta Pranesh praveenx.hodagatta.pranesh@intel.com Gerrit-MessageType: deleteReviewer

HIMANSHU SAHDEV (Code Review)

4:54 p.m.

New subject: Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

HIMANSHU SAHDEV has removed Name of user not set #1002508 from this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Removed reviewer null.

HIMANSHU SAHDEV (Code Review)

4:54 p.m.

New subject: Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

HIMANSHU SAHDEV has removed PraveenX Hodagatta Pranesh from this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Removed reviewer PraveenX Hodagatta Pranesh.

Paul Menzel (Code Review)

30 Jul 30 Jul

4:06 p.m.

New subject: Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG@7 PS2, Line 7: payloads/libpayload libpayload is enough as prefix.

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG@9 PS2, Line 9: This CL allows building a sample libpayload. What error do you get?

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 2 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jul 2019 16:06:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HIMANSHU SAHDEV (Code Review)

31 Jul 31 Jul

4:37 a.m.

New subject: Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

HIMANSHU SAHDEV has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Patch Set 2:

(1 comment)

The path provided for lpgcc and lpas is wrong according to the current directory structure.

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG@9 PS2, Line 9: This CL allows building a sample libpayload.

...

What error do you get?

/bin/sh: 1: ../install/libpayload/bin/lpgcc: not found Makefile:54: recipe for target 'hello.o' failed

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 2 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 31 Jul 2019 04:37:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HIMANSHU SAHDEV (Code Review)

4:38 a.m.

New subject: Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

HIMANSHU SAHDEV has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG@7 PS2, Line 7: payloads/libpayload

...

libpayload is enough as prefix.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 2 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 31 Jul 2019 04:38:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HIMANSHU SAHDEV (Code Review)

4:38 a.m.

New subject: Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

Hello build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34460

to look at the new patch set (#3).

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

libpayload: Fix libpayload directory path in sample libpayload Makefile

This CL allows building a sample libpayload.

Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Signed-off-by: Himanshu Sahdev aka CunningLearner sahdev.himan@gmail.com --- M payloads/libpayload/sample/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/3

HIMANSHU SAHDEV (Code Review)

11:35 a.m.

New subject: Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

Hello build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34460

to look at the new patch set (#5).

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

libpayload: Fix libpayload directory path in sample libpayload Makefile

This CL allows building a sample libpayload.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/5

Paul Menzel (Code Review)

11:47 a.m.

New subject: Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 5 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 31 Jul 2019 11:47:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HIMANSHU SAHDEV (Code Review)

12 Aug 12 Aug

10:15 a.m.

New subject: Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

Hello HAOUAS Elyes, Angel Pons, Paul Menzel, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34460

to look at the new patch set (#7).

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

libpayload: Fix libpayload directory path in sample libpayload Makefile

This CL allows building a sample libpayload. As a normal user if run make and not make install under libpayload gives error when trying to build the sample libpayload.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 7 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

10:26 a.m.

New subject: Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

Name of user not set #1002532 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Patch Set 7: Code-Review+1

Yes, I am able to replicate the same.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 7 Gerrit-Owner: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HIMANSHU SAHDEV sahdev.himan@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002532 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Mon, 12 Aug 2019 10:26:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

8:21 p.m.

New subject: [XS] Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34460?usp=email )

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34460?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968 Gerrit-Change-Number: 34460 Gerrit-PatchSet: 7 Gerrit-Owner: Himanshu Sahdev sahdev.himan@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Himanshu Sahdev sahdev.himan@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin L Roth gaumless@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Sourabh Kashyap Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

321

days inactive

1800

days old

coreboot-gerrit@coreboot.org

15 comments

4 participants

tags (0)

participants (4)

HIMANSHU SAHDEV (Code Review)
Martin L Roth (Code Review)
Name of user not set (Code Review)
Paul Menzel (Code Review)