Change in coreboot[master]: sc7280: Refactor QSPI driver - coreboot-gerrit

16 Aug 2021


      Attention is currently required from: Shelley Chen, Ravi kumar, Sudheer Amrabadi, Julius Werner, mturney mturney.
Rajesh Patil has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55322 )
Change subject: sc7280: Refactor QSPI driver
......................................................................
Patch Set 21:
(1 comment)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/55322/comment/681ff3ee_76ec9122 
PS15, Line 18: #define QSPI_CS        GPIO(15)
             : #define QSPI_DATA_0    GPIO(12)
             : #define QSPI_DATA_1    GPIO(13)
             : #define QSPI_CLK       GPIO(14)
             :
...
Let's follow the tab convention that you've been using for the other #defines (above and below) here […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55322
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1dc3fe8bd71957ff8604ef4c9d97963100ccfb
Gerrit-Change-Number: 55322
Gerrit-PatchSet: 21
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Rajesh Patil rajpat@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Comment-Date: Mon, 16 Aug 2021 05:32:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen shchen@google.com
Gerrit-MessageType: comment