Attention is currently required from: Intel coreboot Reviewers, Martin L Roth, Ronak Kanabar, Sergii Dmytruk.
Paul Menzel has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83738?usp=email )
Change subject: vendorcode/intel: allow selecting EDK headers manually
......................................................................
Patch Set 13: Code-Review+1
(3 comments)
Patchset:
PS13:
Always feel free to mark my comments as resolved.
Commit Message:
https://review.coreboot.org/c/coreboot/+/83738/comment/6553eaf4_47a70b57?usp... :
PS3, Line 7: vendorcode/intel
I think that's because it was initially added for Intel FSP in CB:4015.
Should it be generalized in the future?
https://review.coreboot.org/c/coreboot/+/83738/comment/ce81648d_090e6389?usp... :
PS3, Line 10: This prevents enabling those options
: for boards which don't require EDK bindings.
@paulepanter@mailbox.org, ping.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83738?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I964142ef64967b4c9b329025ebcad701e34a5035
Gerrit-Change-Number: 83738
Gerrit-PatchSet: 13
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Sat, 26 Apr 2025 06:55:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com