Attention is currently required from: Tarun Tuli, Eran Mitrani.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/common, alderlake: provide a list of D-states to enter LPM
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/695bb6cf_ec5cf6a6
PS7, Line 495: return;
I think you need to create a default entry here like what `soc_lpi_get_constraints()` does in `src/soc/intel/common/block/acpi/pep.c`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 7
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 10:03:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment