Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36894 )
Change subject: mb/lenovo/s230u: Don't write BUC and beyond ......................................................................
mb/lenovo/s230u: Don't write BUC and beyond
The BUC register is actually only 16 bits wide and setting bit 5 (disabling GbE) is already done by generic code.
Change-Id: I4b8e14606c319e8bfc48d6757087f28af1bd5dfb Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/lenovo/s230u/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/36894/1
diff --git a/src/mainboard/lenovo/s230u/early_init.c b/src/mainboard/lenovo/s230u/early_init.c index 7c302b8..2de0637 100644 --- a/src/mainboard/lenovo/s230u/early_init.c +++ b/src/mainboard/lenovo/s230u/early_init.c @@ -40,11 +40,6 @@ ec_mm_set_bit(0x3b, 4); }
-void mainboard_late_rcba_config(void) -{ - /* Disable devices. */ - RCBA32(BUC) = 0x00000020; -} const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, { 1, 0, 0 },
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36894 )
Change subject: mb/lenovo/s230u: Don't write BUC and beyond ......................................................................
Patch Set 1: Code-Review+2
Hello Alexander Couzens, Patrick Rudolph, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36894
to look at the new patch set (#2).
Change subject: mb/lenovo/s230u: Don't write BUC and beyond ......................................................................
mb/lenovo/s230u: Don't write BUC and beyond
The BUC register is actually only 8 bits wide and setting bit 5 (disabling GbE) is already done by generic code.
Change-Id: I4b8e14606c319e8bfc48d6757087f28af1bd5dfb Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/lenovo/s230u/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/36894/2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36894 )
Change subject: mb/lenovo/s230u: Don't write BUC and beyond ......................................................................
mb/lenovo/s230u: Don't write BUC and beyond
The BUC register is actually only 8 bits wide and setting bit 5 (disabling GbE) is already done by generic code.
Change-Id: I4b8e14606c319e8bfc48d6757087f28af1bd5dfb Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/36894 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/lenovo/s230u/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/lenovo/s230u/early_init.c b/src/mainboard/lenovo/s230u/early_init.c index 7c302b8..2de0637 100644 --- a/src/mainboard/lenovo/s230u/early_init.c +++ b/src/mainboard/lenovo/s230u/early_init.c @@ -40,11 +40,6 @@ ec_mm_set_bit(0x3b, 4); }
-void mainboard_late_rcba_config(void) -{ - /* Disable devices. */ - RCBA32(BUC) = 0x00000020; -} const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, { 1, 0, 0 },
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)