Change in coreboot[master]: mb/google/guybrush: Move variant_has_fpmcu() after eSPI init - coreboot-gerrit

31 May 2021


      Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54740 )
Change subject: mb/google/guybrush: Move variant_has_fpmcu() after eSPI init
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120343):
https://review.coreboot.org/c/coreboot/+/54740/comment/7434f2e2_9b23585a 
PS3, Line 40: void bootblock_mainboard_init(void){
open brace '{' following function definitions go on the next line
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/54740
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6de44119e92c8820b266f9f07287706c7d4eb505
Gerrit-Change-Number: 54740
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Mon, 31 May 2021 02:14:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment