[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support - coreboot-gerrit

4 Oct 2022


      Attention is currently required from: Michał Żygowski, Piotr Król.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67940 )
Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/protectli/vault_cml/mainboard.c:
https://review.coreboot.org/c/coreboot/+/67940/comment/05634643_e3d72500 
PS7, Line 72: 	beep(1500);
...
Cool, thanks!
Made it optional with Kconfig. Additionally implemented the die notify plus separated beep functon in i8254 driver - CB:68100
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/67940
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b
Gerrit-Change-Number: 67940
Gerrit-PatchSet: 11
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Piotr Król piotr.krol@3mdeb.com
Gerrit-Comment-Date: Tue, 04 Oct 2022 11:18:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment