Attention is currently required from: Paul Menzel, Julius Werner, Yu-Ping Wu.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 )
Change subject: soc/qualcomm/common: Update helper function to know size of memchipinfo
......................................................................
Patch Set 11:
(2 comments)
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/8d26f286_35c60b74
PS10, Line 28: te->size
Please align with te->size above.
thanks for the review. updated in latest patch-set
https://review.coreboot.org/c/coreboot/+/63026/comment/35638e89_2cdcc763
PS10, Line 29: local
Isn't mem_chip_addr a global variable?
thanks for the review. updated in latest patch-set
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63026
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d59669adaf287d0eb7b58ccb0fe3f98e3d23281
Gerrit-Change-Number: 63026
Gerrit-PatchSet: 11
Gerrit-Owner: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 01:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment