Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47802 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Correct comment ......................................................................
drivers/intel/fsp1_1/cache_as_ram.S: Correct comment
Stack is setup for bootblock
Tested on Facebook FBG1701
Change-Id: I0dd3fc91c90bf76e0d93925da35dc197d68d3e88 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/drivers/intel/fsp1_1/cache_as_ram.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47802/1
diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.S b/src/drivers/intel/fsp1_1/cache_as_ram.S index 3be9eb9..ce1ee9c 100644 --- a/src/drivers/intel/fsp1_1/cache_as_ram.S +++ b/src/drivers/intel/fsp1_1/cache_as_ram.S @@ -132,7 +132,7 @@ cmp $0, %eax jne halt2
- /* Setup bootloader stack */ + /* Setup bootblock stack */ movl $_ecar_stack, %esp
/*
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47802 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Correct comment ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47802/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47802/1//COMMIT_MSG@9 PS1, Line 9: setup set up
Hello build bot (Jenkins), Lee Leahy, Paul Menzel, Huang Jin, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47802
to look at the new patch set (#2).
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Correct comment ......................................................................
drivers/intel/fsp1_1/cache_as_ram.S: Correct comment
Stack is set up for bootblock.
Tested on Facebook FBG1701.
Change-Id: I0dd3fc91c90bf76e0d93925da35dc197d68d3e88 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/drivers/intel/fsp1_1/cache_as_ram.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47802/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47802 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Correct comment ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47802/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47802/1//COMMIT_MSG@9 PS1, Line 9: setup
set up
Done
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47802 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Correct comment ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47802 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Correct comment ......................................................................
drivers/intel/fsp1_1/cache_as_ram.S: Correct comment
Stack is set up for bootblock.
Tested on Facebook FBG1701.
Change-Id: I0dd3fc91c90bf76e0d93925da35dc197d68d3e88 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47802 Reviewed-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/fsp1_1/cache_as_ram.S 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Wim Vervoorn: Looks good to me, approved
diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.S b/src/drivers/intel/fsp1_1/cache_as_ram.S index f2d29aa..f1cfff7 100644 --- a/src/drivers/intel/fsp1_1/cache_as_ram.S +++ b/src/drivers/intel/fsp1_1/cache_as_ram.S @@ -132,7 +132,7 @@ cmp $0, %eax jne halt2
- /* Setup bootloader stack */ + /* Setup bootblock stack */ movl $_ecar_stack, %esp
/*
-
Frans Hendriks (Code Review) -
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)
-
Wim Vervoorn (Code Review)