Attention is currently required from: Michał Żygowski, Michał Kopeć. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 )
Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Would you mind basing this on CB:59548, where the structure is as it should be already? I'll push an update
File src/mainboard/clevo/tgl-u/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62498/comment/da18137b_fa8e3359 PS1, Line 16: if (onoff) { : gpio_set(DGPU_RST_N, 0); : mdelay(4); : gpio_set(DGPU_PWR_EN, 1); : mdelay(4); : gpio_set(DGPU_RST_N, 1); : } else { : gpio_set(DGPU_RST_N, 0); : mdelay(4); : gpio_set(DGPU_PWR_EN, 0); hmm, this looks like non-board-specific, generic code, that should be located in src/driver somewhere