Attention is currently required from: Julius Werner, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86228?usp=email )
Change subject: vc/google/chromeos: Implement platform callback for critical shutdown ......................................................................
Patch Set 4:
(2 comments)
File src/vendorcode/google/chromeos/battery.c:
https://review.coreboot.org/c/coreboot/+/86228/comment/f9d53f82_67745965?usp... : PS4, Line 35: checked = true;
No, this needs to be outside the inner `if`. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/86228/comment/1e8f7d43_69ae4257?usp... : PS4, Line 50: * 3. If in romstage and Chrome EC is supported, sends a shutdown command to the EC.
Why the romstage/ramstage difference? You're saying what the code does but you're not explaining _wh […]
Acknowledged