Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68018 )
(
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/skyrim: Adjust Makefile to look for SPD ......................................................................
mb/google/skyrim: Adjust Makefile to look for SPD
Adjust the Makefile to look for SPD source Makefile. The current SPD guard isn't set up correctly and is attempting to build the APCB with SPD when SPD isn't present.
BUG=b:249988439 TEST=util/abuild/abuild -x -t GOOGLE_MORTHAL --verbose util/abuild/abuild -x -t GOOGLE_SKYRIM --verbose util/abuild/abuild -x -t GOOGLE_WINTERHOLD --verbose
Change-Id: I9cf13acb1188309ea6a1e6bdacc37d80b01f70a8 Signed-off-by: Jon Murphy jpmurphy@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/68018 Reviewed-by: Robert Zieba robertzieba@google.com Reviewed-by: Tim Van Patten timvp@google.com Reviewed-by: Martin Roth martin.roth@amd.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/skyrim/Makefile.inc 1 file changed, 25 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Robert Zieba: Looks good to me, but someone else must approve Tim Van Patten: Looks good to me, but someone else must approve Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/Makefile.inc b/src/mainboard/google/skyrim/Makefile.inc index 869916e..ba175a2 100644 --- a/src/mainboard/google/skyrim/Makefile.inc +++ b/src/mainboard/google/skyrim/Makefile.inc @@ -19,7 +19,7 @@ ifneq ($(wildcard $(MAINBOARD_BLOBS_DIR)/APCB_MDN_D5.bin),) $(info APCB sources present.)
-ifneq ($(wildcard $(top)/$(SPD_SOURCES)),) +ifneq ($(wildcard $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memory/Makefile.inc),)
LIB_SPD_DEPS = $(SPD_SOURCES)