Change in coreboot[master]: soc/intel/broadwell/sata.c: Don't enable Bus Master

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47026 )

Change subject: soc/intel/broadwell/sata.c: Don't enable Bus Master
......................................................................

soc/intel/broadwell/sata.c: Don't enable Bus Master

Bus Master is not required and reference code does not set it.

Change-Id: I2f70486f96cf3dcaba74283293b93b9747cd0300
Signed-off-by: Angel Pons 
---
M src/soc/intel/broadwell/pch/sata.c
1 file changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/47026/1

diff --git a/src/soc/intel/broadwell/pch/sata.c b/src/soc/intel/broadwell/pch/sata.c
index ab73dbd..8b2c513 100644
--- a/src/soc/intel/broadwell/pch/sata.c
+++ b/src/soc/intel/broadwell/pch/sata.c
@@ -44,9 +44,8 @@

printk(BIOS_DEBUG, "SATA: Initializing controller in AHCI mode.\n");

-	/* Enable BARs */
-	pci_write_config16(dev, PCI_COMMAND,
-			   PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY | PCI_COMMAND_IO);
+	/* Enable memory space decoding for ABAR */
+	pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MEMORY | PCI_COMMAND_IO);

/* Set Interrupt Line */
    /* Interrupt Pin is set by D31IP.PIP */

Change in coreboot[master]: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master

[Angel Pons (Code Review)]

Hello  Felix Singer, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47026

to look at the new patch set (#2).

Change subject: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master
......................................................................

soc/intel/broadwell/pch/sata.c: Don't enable Bus Master

Bus Master is not required and reference code does not set it.

Change-Id: I2f70486f96cf3dcaba74283293b93b9747cd0300
Signed-off-by: Angel Pons 
---
M src/soc/intel/broadwell/pch/sata.c
1 file changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/47026/2

Change in coreboot[master]: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47026 )

Change subject: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/47026/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47026/2//COMMIT_MSG@9 
PS2, Line 9: Bus Master is not required and reference code does not set it.
Did you test it and does it still work?

Change in coreboot[master]: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47026 )

Change subject: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47026/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47026/2//COMMIT_MSG@9 
PS2, Line 9: Bus Master is not required and reference code does not set it.
> Did you test it and does it still work?

Not yet, but there's a hundred commits before this one. There's plenty of time to test 😄

Change in coreboot[master]: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master

[Angel Pons (Code Review)]

Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/47026 )

Change subject: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master
......................................................................

Removed Verified+1 by build bot (Jenkins)

Change in coreboot[master]: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47026 )

Change subject: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master
......................................................................

Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/47026/comment/7cb214ec_a4904be7 
PS2, Line 9: Bus Master is not required and reference code does not set it.
> Not yet, but there's a hundred commits before this one. […]

Works.

Change in coreboot[master]: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47026 )

Change subject: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master
......................................................................

soc/intel/broadwell/pch/sata.c: Don't enable Bus Master

Bus Master is not required and reference code does not set it.

Change-Id: I2f70486f96cf3dcaba74283293b93b9747cd0300
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47026
Tested-by: build bot (Jenkins) 
Reviewed-by:  Felix Singer 
---
M src/soc/intel/broadwell/pch/sata.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
   Felix Singer: Looks good to me, approved

diff --git a/src/soc/intel/broadwell/pch/sata.c b/src/soc/intel/broadwell/pch/sata.c
index b496e53..82760ab 100644
--- a/src/soc/intel/broadwell/pch/sata.c
+++ b/src/soc/intel/broadwell/pch/sata.c
@@ -35,9 +35,8 @@

printk(BIOS_DEBUG, "SATA: Initializing controller in AHCI mode.\n");

-	/* Enable BARs */
-	pci_write_config16(dev, PCI_COMMAND,
-			   PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY | PCI_COMMAND_IO);
+	/* Enable memory space decoding for ABAR */
+	pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MEMORY | PCI_COMMAND_IO);

/* Set Interrupt Line */
    /* Interrupt Pin is set by D31IP.PIP */