Attention is currently required from: Jason Glenesk, Marshall Dawson, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62579 )
Change subject: [UNTESTED] soc/amd/common/block/lpc/lpc: rework resource index handling
......................................................................
Patch Set 1:
(4 comments)
File src/soc/amd/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/62579/comment/ad833f27_45528ec6
PS1, Line 96: IOINDEX_SUBTRACTIVE
lol.... what!
https://review.coreboot.org/c/coreboot/+/62579/comment/968f96af_c15c1944
PS1, Line 102: IORESOURCE_SUBTRACTIVE
I don't understand why this is subtractive?
https://review.coreboot.org/c/coreboot/+/62579/comment/51b2e091_15d40b57
PS1, Line 114: IORESOURCE_SUBTRACTIVE
Same with this?
https://review.coreboot.org/c/coreboot/+/62579/comment/2f6432de_bcd021c0
PS1, Line 130: STAY
Who disables them?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62579
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38b2845c982e01f263e70e9639dc2d8a3a7f6925
Gerrit-Change-Number: 62579
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 04 Mar 2022 15:56:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment