build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29478 )
Change subject: device/i2c_bus: Add i2c_dev_readb_at_word() ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/29478/2/src/device/i2c_bus.c File src/device/i2c_bus.c:
https://review.coreboot.org/#/c/29478/2/src/device/i2c_bus.c@189 PS2, Line 189: transfer(busdev, msg, ARRAY_SIZE(msg)); Avoid multiple line dereference - prefer 'busdev->ops->ops_i2c_bus->transfer'
https://review.coreboot.org/#/c/29478/2/src/include/device/i2c_bus.h File src/include/device/i2c_bus.h:
https://review.coreboot.org/#/c/29478/2/src/include/device/i2c_bus.h@98 PS2, Line 98: int i2c_dev_readb_at_word(struct device *, function definition argument 'struct device *' should also have an identifier name