Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Morgan Jang, Patrick Rudolph, Tim Chu.
Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85557?usp=email )
Change subject: soc/intel/xeon_sp: Merge SKX and CPX ......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85557/comment/c4393098_cfee49da?usp... : PS5, Line 10: - Create a new 14nm folder
There are '(xx)nm - old' and 'intel(x) - new' for process namings which is confusing. […]
Is there an Intel name for the "Xeon-SP SPR and CPX" group?
File src/soc/intel/xeon_sp/14nm/Kconfig:
https://review.coreboot.org/c/coreboot/+/85557/comment/601db22f_ab6500bc?usp... : PS5, Line 9: Intel 14nm SoC (CPUID 506fx and CPUID 5065x) ```suggestion Intel Xeon-SP 14nm SoC (CPUID 506fx and CPUID 5065x) ```
File src/soc/intel/xeon_sp/14nm/cpu.c:
https://review.coreboot.org/c/coreboot/+/85557/comment/946d8768_a99564bd?usp... : PS5, Line 86: assert(chip_config); Not sure if losing this is important
File src/soc/intel/xeon_sp/cpx/Kconfig:
https://review.coreboot.org/c/coreboot/+/85557/comment/ce43f2e7_24c2ee69?usp... : PS5, Line 5: select SOC_INTEL_XEON_SP_14NM
Maybe we can have a SOC_INTEL_XEON_SP_GEN3 but select the same kconfigs as SOC_INTEL_XEON_SP_GEN1
I don't know what GEN1 and GEN3 correspond to, SKX and CPX respectively?