Attention is currently required from: Kyösti Mälkki. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58386 )
Change subject: cpu/x86/lapic: Use CPUID leaf 0xb without X2APIC ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58386/comment/71d56cfa_a17fe578 PS1, Line 7: cpu/x86/lapic: Use CPUID leaf 0xb without X2APIC maybe:
cpu/x86/lapic: unconditionally use CPUID leaf 0xb if available
Even when we're not in X2APIC mode, the information in CPUID leaf 0xb will be valid if that leaf is implemented on the CPU.
Patchset:
PS1: the code looks correct to me