Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77678?usp=email )
Change subject: mb/google/skyrim/frostflow: Drop GPIO override for camera shutter ......................................................................
mb/google/skyrim/frostflow: Drop GPIO override for camera shutter
Appears to not be used under Windows, Linux, or ChromeOS, and causes high CPU usage at idle under Windows.
BUG=none TEST=build/boot Win11, Linux on google/frostflow, verify camera shutter function unchanged, CPU usage under Windows idles where expected.
Change-Id: I8a6ea3b886766bdb055b40949c75bec0264eecc5 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/77678 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/google/skyrim/variants/frostflow/gpio.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: Karthik Ramasubramanian: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/variants/frostflow/gpio.c b/src/mainboard/google/skyrim/variants/frostflow/gpio.c index 45ead98..a063159 100644 --- a/src/mainboard/google/skyrim/variants/frostflow/gpio.c +++ b/src/mainboard/google/skyrim/variants/frostflow/gpio.c @@ -7,8 +7,6 @@
/* GPIO configuration in ramstage */ static const struct soc_amd_gpio override_gpio_table[] = { - /* EN_PWR_WWAN_X => CAM_PSW_L */ - PAD_INT(GPIO_8, PULL_NONE, BOTH_EDGES, STATUS_DELIVERY), /* SOC_SAR_INT_L => Unused */ PAD_NC(GPIO_17), /* WWAN_RST_L => Unused */