Attention is currently required from: Matt DeVillier, Nick Vaccaro.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74852 )
Change subject: mb/google/volteer: Add VBT data files for variants
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74852/comment/1101094e_5e2dd39f
PS2, Line 10: Several boards use the same VBT, so put it under
: the baseboard and make it the default;
Found that hard to read, maybe:
- Place the common VBT under the baseboard directory and set it as the default
- For variants with a unique VBT, override the default and use the file in their respective directories
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74852
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I728ab81938c78f600ff8931a8073d1f7de152c09
Gerrit-Change-Number: 74852
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Sat, 29 Apr 2023 20:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment