Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36565 )
Change subject: soc/intel/common: pmclib: add API to get ETR register MMCONF address
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36565/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/36565/1/src/soc/intel/common/block/...
PS1, Line 173: uintptr_t soc_read_pmc_etr_mmconf_addr(void);
I guess Aaron's idea was to have a common interface for all platforms,
i.e. just return the address, no matter if that is in MMCONF or MMIO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I706f3e220d639a6133625e3cb7267f7009006af2
Gerrit-Change-Number: 36565
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 02 Nov 2019 13:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment