HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36227 )
Change subject: sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments ......................................................................
sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments
Change-Id: Ied64879d294670d452845ff47d417d595b72864a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/cimx/sb800/late.c M src/southbridge/amd/cimx/sb800/smbus.c M src/southbridge/amd/cimx/sb900/late.c M src/southbridge/amd/cimx/sb900/lpc.c M src/southbridge/amd/cimx/sb900/smbus.c 5 files changed, 9 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/36227/1
diff --git a/src/southbridge/amd/cimx/sb800/late.c b/src/southbridge/amd/cimx/sb800/late.c index 4233a6f..67938c5 100644 --- a/src/southbridge/amd/cimx/sb800/late.c +++ b/src/southbridge/amd/cimx/sb800/late.c @@ -17,16 +17,16 @@
#include <device/mmio.h> #include <device/device.h> -#include <device/pci.h> /* device_operations */ +#include <device/pci.h> #include <device/pci_ops.h> #include <device/pci_ids.h> #include <bootstate.h> #include <arch/ioapic.h> -#include <device/smbus.h> /* smbus_bus_operations */ +#include <device/smbus.h> #include <pc80/mc146818rtc.h> #include <pc80/i8254.h> #include <pc80/i8259.h> -#include <console/console.h> /* printk */ +#include <console/console.h> #include <arch/acpi.h> #include <device/pci_ehci.h> #include "lpc.h" /* lpc_read_resources */ diff --git a/src/southbridge/amd/cimx/sb800/smbus.c b/src/southbridge/amd/cimx/sb800/smbus.c index a4426ff..f54bcd3 100644 --- a/src/southbridge/amd/cimx/sb800/smbus.c +++ b/src/southbridge/amd/cimx/sb800/smbus.c @@ -13,10 +13,9 @@ * GNU General Public License for more details. */
- #include <arch/io.h> #include "smbus.h" -#include <console/console.h> /* printk */ +#include <console/console.h>
static int smbus_wait_until_ready(u32 smbus_io_base) { diff --git a/src/southbridge/amd/cimx/sb900/late.c b/src/southbridge/amd/cimx/sb900/late.c index 3a65e33..423b996 100644 --- a/src/southbridge/amd/cimx/sb900/late.c +++ b/src/southbridge/amd/cimx/sb900/late.c @@ -13,15 +13,14 @@ * GNU General Public License for more details. */
- #include <device/device.h> -#include <device/pci.h> /* device_operations */ +#include <device/pci.h> #include <device/pci_ids.h> -#include <device/smbus.h> /* smbus_bus_operations */ +#include <device/smbus.h> #include <pc80/mc146818rtc.h> #include <pc80/i8254.h> #include <pc80/i8259.h> -#include <console/console.h> /* printk */ +#include <console/console.h> #include <device/pci_ehci.h> #include <arch/acpi.h> #include "lpc.h" /* lpc_read_resources */ diff --git a/src/southbridge/amd/cimx/sb900/lpc.c b/src/southbridge/amd/cimx/sb900/lpc.c index 8e7c1cc..3f365bd 100644 --- a/src/southbridge/amd/cimx/sb900/lpc.c +++ b/src/southbridge/amd/cimx/sb900/lpc.c @@ -16,10 +16,9 @@ #include <device/pci.h> #include <device/pci_ops.h> #include "lpc.h" -#include <console/console.h> /* printk */ +#include <console/console.h> #include <arch/ioapic.h>
- void lpc_read_resources(struct device *dev) { struct resource *res; diff --git a/src/southbridge/amd/cimx/sb900/smbus.c b/src/southbridge/amd/cimx/sb900/smbus.c index 389aa8e..cc76c64 100644 --- a/src/southbridge/amd/cimx/sb900/smbus.c +++ b/src/southbridge/amd/cimx/sb900/smbus.c @@ -13,10 +13,9 @@ * GNU General Public License for more details. */
- #include <arch/io.h> #include "smbus.h" -#include <console/console.h> /* printk */ +#include <console/console.h>
static int smbus_wait_until_ready(u32 smbus_io_base) {
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36227
to look at the new patch set (#2).
Change subject: sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments ......................................................................
sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments
Change-Id: Ied64879d294670d452845ff47d417d595b72864a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/cimx/sb800/late.c M src/southbridge/amd/cimx/sb800/smbus.c M src/southbridge/amd/cimx/sb900/late.c M src/southbridge/amd/cimx/sb900/lpc.c M src/southbridge/amd/cimx/sb900/smbus.c 5 files changed, 9 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/36227/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36227 )
Change subject: sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments ......................................................................
Patch Set 2:
Why not leave the comments?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36227 )
Change subject: sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments ......................................................................
Patch Set 2:
Patch Set 2:
Why not leave the comments?
they are not useful.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36227
to look at the new patch set (#3).
Change subject: sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments ......................................................................
sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments
Change-Id: Ied64879d294670d452845ff47d417d595b72864a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/cimx/sb800/late.c M src/southbridge/amd/cimx/sb800/smbus.c 2 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/36227/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36227
to look at the new patch set (#4).
Change subject: sb/amd/cimx/sb800: Remove some superfluous comments ......................................................................
sb/amd/cimx/sb800: Remove some superfluous comments
Change-Id: Ied64879d294670d452845ff47d417d595b72864a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/cimx/sb800/late.c M src/southbridge/amd/cimx/sb800/smbus.c 2 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/36227/4
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36227 )
Change subject: sb/amd/cimx/sb800: Remove some superfluous comments ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Paul Menzel (Code Review)