Change in coreboot[master]: [WIP] mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41703 )
Change subject: [WIP] mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI ......................................................................
[WIP] mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI
Change-Id: If25ed7b5cc545abcbf16af66173058dde75260f7 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/icelake_rvp/Kconfig M src/mainboard/intel/jasperlake_rvp/Kconfig 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/41703/1
diff --git a/src/mainboard/intel/icelake_rvp/Kconfig b/src/mainboard/intel/icelake_rvp/Kconfig index 8331f1b..834ccc8 100644 --- a/src/mainboard/intel/icelake_rvp/Kconfig +++ b/src/mainboard/intel/icelake_rvp/Kconfig @@ -11,6 +11,7 @@ select GENERIC_SPD_BIN select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC + select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_ICELAKE diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig b/src/mainboard/intel/jasperlake_rvp/Kconfig index a1283bd..af08c23 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig @@ -7,6 +7,7 @@ select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC select DRIVERS_I2C_MAX98373 + select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select EC_ACPI select GENERIC_SPD_BIN
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41703 )
Change subject: [WIP] mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI ......................................................................
Patch Set 2: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41703 )
Change subject: [WIP] mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41703/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41703/4//COMMIT_MSG@7 PS4, Line 7: [WIP] Can be removed now?
Hello Varshit B Pandya, build bot (Jenkins), Furquan Shaikh, Subrata Banik, Angel Pons, Aamir Bohra,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41703
to look at the new patch set (#5).
Change subject: mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI ......................................................................
mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI
Change-Id: If25ed7b5cc545abcbf16af66173058dde75260f7 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/icelake_rvp/Kconfig M src/mainboard/intel/jasperlake_rvp/Kconfig 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/41703/5
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41703 )
Change subject: mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41703/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41703/4//COMMIT_MSG@7 PS4, Line 7: [WIP]
Can be removed now?
Lost +2 votes with rebase and fixed subject lines on the series.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41703 )
Change subject: mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI ......................................................................
Patch Set 5: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41703 )
Change subject: mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI ......................................................................
Patch Set 5: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41703 )
Change subject: mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI ......................................................................
mb/intel/icelake_rvp,jasperlake_rvp: Select DRIVERS_SPI_ACPI
Change-Id: If25ed7b5cc545abcbf16af66173058dde75260f7 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41703 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/icelake_rvp/Kconfig M src/mainboard/intel/jasperlake_rvp/Kconfig 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/intel/icelake_rvp/Kconfig b/src/mainboard/intel/icelake_rvp/Kconfig index 952ae3e..2743384 100644 --- a/src/mainboard/intel/icelake_rvp/Kconfig +++ b/src/mainboard/intel/icelake_rvp/Kconfig @@ -11,6 +11,7 @@ select GENERIC_SPD_BIN select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC + select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_ICELAKE diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig b/src/mainboard/intel/jasperlake_rvp/Kconfig index b14f07f..b56e22a 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig @@ -7,6 +7,7 @@ select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC select DRIVERS_I2C_MAX98373 + select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select EC_ACPI select GENERIC_SPD_BIN
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)