Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Xin Ji has posted comments on this change by Xin Ji. ( https://review.coreboot.org/c/coreboot/+/86101?usp=email )
Change subject: mb/google/corsola: Increase ANX7625 data trail time
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86101/comment/777939d4_02a42792?usp... :
PS3, Line 10: shorter
too short
Acknowledged
https://review.coreboot.org/c/coreboot/+/86101/comment/131121c0_70575684?usp... :
PS3, Line 10: caused
is caused
Acknowledged
https://review.coreboot.org/c/coreboot/+/86101/comment/d0ef2f08_32afbb6c?usp... :
PS3, Line 13: enter
entering
Acknowledged
https://review.coreboot.org/c/coreboot/+/86101/comment/f582290e_74876c24?usp... :
PS3, Line 15:
So why is +9 correct, and not +11 or +8?
This value is migrated from "kukui/panel_anx7625.c". And verified on corsola.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86101?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I677667240c7f3b0e14c6a728931921e32f539c57
Gerrit-Change-Number: 86101
Gerrit-PatchSet: 3
Gerrit-Owner: Xin Ji
xji@analogix.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 23 Jan 2025 01:56:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org